<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107807/">http://git.reviewboard.kde.org/r/107807/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While I am pretty sure this patch does not break something, it's quite some lines, so I think you prefer to have another pair of eyes check this.
Patch removes usages of QString::null, resetting a QString by = QString() and unneeded reinitialisations in constructors.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No changes in unit tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h <span style="color: grey">(442ac67)</span></li>
<li>filters/libmsooxml/MsooXmlDrawingTableStyleReader.cpp <span style="color: grey">(ec1963c)</span></li>
<li>filters/libmsooxml/MsooXmlVmlReaderImpl.h <span style="color: grey">(0c3a7b1)</span></li>
<li>filters/sheets/excel/sidewinder/excel.cpp <span style="color: grey">(72c3fbe)</span></li>
<li>filters/sheets/excel/sidewinder/utils.cpp <span style="color: grey">(01b92a4)</span></li>
<li>filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp <span style="color: grey">(757d42b)</span></li>
<li>filters/words/docx/DocxXmlDocumentReader.cpp <span style="color: grey">(634d3b9)</span></li>
<li>filters/words/docx/DocxXmlNumberingReader.cpp <span style="color: grey">(6295a93)</span></li>
<li>filters/words/msword-odf/texthandler.h <span style="color: grey">(e80f8ad)</span></li>
<li>kexi/kexiutils/KexiCommandLinkButton.cpp <span style="color: grey">(35d1119)</span></li>
<li>kexi/plugins/queries/kexiquerydesignerguieditor.cpp <span style="color: grey">(e3a9cab)</span></li>
<li>krita/image/tests/kis_base_node_test.cpp <span style="color: grey">(2329b8f)</span></li>
<li>krita/image/tests/kis_paint_device_test.cpp <span style="color: grey">(071e5e3)</span></li>
<li>krita/plugins/formats/psd/psd_layer_section.cpp <span style="color: grey">(4e13395)</span></li>
<li>krita/plugins/paintops/libbrush/abrbrush.cpp <span style="color: grey">(0deb375)</span></li>
<li>krita/plugins/paintops/libbrush/kis_abr_brush.cpp <span style="color: grey">(3abf1dd)</span></li>
<li>krita/plugins/paintops/libbrush/kis_abr_brush_collection.cpp <span style="color: grey">(1539a3a)</span></li>
<li>krita/plugins/paintops/libbrush/kis_abr_translator.h <span style="color: grey">(bccc4bc)</span></li>
<li>krita/plugins/paintops/libbrush/kis_abr_translator.cpp <span style="color: grey">(0367156)</span></li>
<li>krita/ui/kra/kis_kra_loader.cpp <span style="color: grey">(8c8ecd9)</span></li>
<li>libs/flake/KoShapeFactoryBase.h <span style="color: grey">(5722148)</span></li>
<li>libs/flake/KoShapeSavingContext.h <span style="color: grey">(4801b29)</span></li>
<li>libs/flake/KoToolManager.cpp <span style="color: grey">(4e09a8d)</span></li>
<li>libs/koreport/wrtembed/KoReportDesigner.cpp <span style="color: grey">(e6eff07)</span></li>
<li>libs/main/rdf/KoDocumentRdf.cpp <span style="color: grey">(4c60090)</span></li>
<li>libs/odf/KoElementReference.cpp <span style="color: grey">(b51f97f)</span></li>
<li>libs/odf/KoOdfBibliographyConfiguration.cpp <span style="color: grey">(19799cc)</span></li>
<li>libs/odf/KoOdfLineNumberingConfiguration.cpp <span style="color: grey">(8fefb48)</span></li>
<li>libs/odf/KoOdfNotesConfiguration.cpp <span style="color: grey">(a456eb0)</span></li>
<li>libs/odf/KoOdfNumberDefinition.cpp <span style="color: grey">(d87120a)</span></li>
<li>libs/odf/tests/kodomtest.cpp <span style="color: grey">(fd7defc)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/ycbcr_f32/YCbCrF32ColorSpace.h <span style="color: grey">(01f16ba)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/ycbcr_u16/YCbCrU16ColorSpace.h <span style="color: grey">(81796e5)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/ycbcr_u8/YCbCrU8ColorSpace.h <span style="color: grey">(78d00ca)</span></li>
<li>stage/part/KPrViewModeSlidesSorter.cpp <span style="color: grey">(ca3d9b5)</span></li>
<li>words/part/KWPageStyle.cpp <span style="color: grey">(0faab80)</span></li>
<li>words/part/dialogs/KWAnchoringProperties.cpp <span style="color: grey">(558b48c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107807/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>