<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107647/">http://git.reviewboard.kde.org/r/107647/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Almost ready! Please carefully fix the issues.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107647/diff/5-6/?file=98594#file98594line231" style="color: black; font-weight: bold; text-decoration: underline;">kexi/formeditor/container.h</a>
<span style="font-weight: normal;">
(Diff revisions 5 - 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">229</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ObjectTreeItem</span><span class="o">*</span> <span class="n">m_item</span><span class="p">;</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">231</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ObjectTreeItem</span><span class="o">*</span> <span class="n">m_item</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move m_item to Private</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107647/diff/5-6/?file=98614#file98614line267" style="color: black; font-weight: bold; text-decoration: underline;">kexi/formeditor/widgetfactory.h</a>
<span style="font-weight: normal;">
(Diff revisions 5 - 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">267</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n"><span class="hl">property</span>Desc<span class="hl">ForValue</span></span><span class="p">(</span><span class="k">const</span> <span class="n"><span class="hl">QByteArray</span></span><span class="hl"> </span><span class="o"><span class="hl">&</span></span><span class="n">name</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">267</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n"><span class="hl">value</span>Desc<span class="hl">ription</span></span><span class="p">(</span><span class="k">const</span> <span class="kt"><span class="hl">char</span></span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="n">name</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">--> QString valueDescription(const char* name) const;</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107647/diff/5-6/?file=98614#file98614line355" style="color: black; font-weight: bold; text-decoration: underline;">kexi/formeditor/widgetfactory.h</a>
<span style="font-weight: normal;">
(Diff revisions 5 - 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">protected:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">352</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">WidgetInfo</span><span class="o">*</span> <span class="n">widgetInfoForClassName</span><span class="p">(</span><span class="k">const</span> <span class="kt">char</span><span class="o">*</span> <span class="n">classname</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move ALL these methods down to protected section</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107647/diff/5-6/?file=98615#file98615line330" style="color: black; font-weight: bold; text-decoration: underline;">kexi/formeditor/widgetfactory.cpp</a>
<span style="font-weight: normal;">
(Diff revisions 5 - 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void WidgetFactory::setInternalProperty(const QByteArray &classname, const QByteArray &property, const QVariant &value)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">329</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">d</span><span class="o">-></span><span class="n">propDesc</span><span class="p">[</span><span class="n">name</span><span class="p">];</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">330</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">d</span><span class="o">-></span><span class="n">propDesc</span><span class="p">[</span><span class="n">name</span><span class="p">];</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">change to d->propDesc.value(name)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107647/diff/5-6/?file=98615#file98615line335" style="color: black; font-weight: bold; text-decoration: underline;">kexi/formeditor/widgetfactory.cpp</a>
<span style="font-weight: normal;">
(Diff revisions 5 - 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void WidgetFactory::setInternalProperty(const QByteArray &classname, const QByteArray &property, const QVariant &value)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">334</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">d</span><span class="o">-></span><span class="n">propValDesc</span><span class="p">[</span><span class="n">name</span><span class="p">];</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">335</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">d</span><span class="o">-></span><span class="n">propValDesc</span><span class="p">[</span><span class="n">name</span><span class="p">];</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">change to d->propValDesc.value(name)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107647/diff/5-6/?file=98615#file98615line340" style="color: black; font-weight: bold; text-decoration: underline;">kexi/formeditor/widgetfactory.cpp</a>
<span style="font-weight: normal;">
(Diff revisions 5 - 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void WidgetFactory::setInternalProperty(const QByteArray &classname, const QByteArray &property, const QVariant &value)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">339</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">d</span><span class="o">-></span><span class="n">classesByName</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">340</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">d</span><span class="o">-></span><span class="n">classesByName</span><span class="p"><span class="hl">[</span></span><span class="n"><span class="hl">classname</span></span><span class="p"><span class="hl">]</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">change to
return d->classesByName.value(classname);</pre>
</div>
<br />
<p>- Jarosław</p>
<br />
<p>On December 13th, 2012, 10:14 a.m., Andrey Inishev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Andrey Inishev.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2012, 10:14 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch adding d-pointers to kexi/formeditor</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/formeditor/FormWidget.h <span style="color: grey">(87b3889)</span></li>
<li>kexi/formeditor/FormWidget.cpp <span style="color: grey">(bb83f98)</span></li>
<li>kexi/formeditor/WidgetTreeWidget.h <span style="color: grey">(01d3727)</span></li>
<li>kexi/formeditor/WidgetTreeWidget.cpp <span style="color: grey">(a90aa01)</span></li>
<li>kexi/formeditor/connectiondialog.h <span style="color: grey">(712ebe0)</span></li>
<li>kexi/formeditor/connectiondialog.cpp <span style="color: grey">(d89c46c)</span></li>
<li>kexi/formeditor/container.h <span style="color: grey">(696361e)</span></li>
<li>kexi/formeditor/container.cpp <span style="color: grey">(26d2f78)</span></li>
<li>kexi/formeditor/events.h <span style="color: grey">(ea498c5)</span></li>
<li>kexi/formeditor/events.cpp <span style="color: grey">(04c5394)</span></li>
<li>kexi/formeditor/factories/containerfactory.cpp <span style="color: grey">(95f155f)</span></li>
<li>kexi/formeditor/factories/stdwidgetfactory.cpp <span style="color: grey">(b010745)</span></li>
<li>kexi/formeditor/form.cpp <span style="color: grey">(7f884ff)</span></li>
<li>kexi/formeditor/formIO.cpp <span style="color: grey">(ee11860)</span></li>
<li>kexi/formeditor/kexiformeventhandler.h <span style="color: grey">(4482ba3)</span></li>
<li>kexi/formeditor/kexiformeventhandler.cpp <span style="color: grey">(97face3)</span></li>
<li>kexi/formeditor/libactionwidget.h <span style="color: grey">(63b120e)</span></li>
<li>kexi/formeditor/libactionwidget.cpp <span style="color: grey">(bc5d2bf)</span></li>
<li>kexi/formeditor/objecttree.h <span style="color: grey">(a37c220)</span></li>
<li>kexi/formeditor/objecttree.cpp <span style="color: grey">(4544781)</span></li>
<li>kexi/formeditor/resizehandle.h <span style="color: grey">(c2b5116)</span></li>
<li>kexi/formeditor/resizehandle.cpp <span style="color: grey">(4d70b0f)</span></li>
<li>kexi/formeditor/richtextdialog.h <span style="color: grey">(5b8fc73)</span></li>
<li>kexi/formeditor/richtextdialog.cpp <span style="color: grey">(3aa27f7)</span></li>
<li>kexi/formeditor/tabstopdialog.h <span style="color: grey">(d725344)</span></li>
<li>kexi/formeditor/tabstopdialog.cpp <span style="color: grey">(f45e56a)</span></li>
<li>kexi/formeditor/widgetfactory.h <span style="color: grey">(0dd8c46)</span></li>
<li>kexi/formeditor/widgetfactory.cpp <span style="color: grey">(145d513)</span></li>
<li>kexi/formeditor/widgetlibrary.h <span style="color: grey">(81006cf)</span></li>
<li>kexi/formeditor/widgetlibrary.cpp <span style="color: grey">(4e3a941)</span></li>
<li>kexi/formeditor/widgetwithsubpropertiesinterface.h <span style="color: grey">(9b51b52)</span></li>
<li>kexi/formeditor/widgetwithsubpropertiesinterface.cpp <span style="color: grey">(7d80f82)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107647/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>