<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107610/">http://git.reviewboard.kde.org/r/107610/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107610/diff/1/?file=97428#file97428line297" style="color: black; font-weight: bold; text-decoration: underline;">kexi/migration/keximigrate.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">protected:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">297</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KexiMigration</span><span class="o">::</span><span class="n">Data</span><span class="o">*</span> <span class="n">m_migrateData</span><span class="p">;</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">295</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KexiMigration</span><span class="o">::</span><span class="n">Data</span><span class="o">*</span> <span class="n">m_migrateData</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still not removed...</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107610/diff/1/?file=97431#file97431line309" style="color: black; font-weight: bold; text-decoration: underline;">kexi/plugins/importexport/csv/kexicsvwidgets.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QFrame* KexiCSVInfoLabel::separator() const {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">296</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QLabel</span><span class="o">*</span> <span class="n">KexiCSVInfoLabel</span><span class="o">::</span><span class="n">fileNameLabel</span><span class="p">()</span> <span class="k">const</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please move '{' to new line.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107610/diff/1/?file=97432#file97432line44" style="color: black; font-weight: bold; text-decoration: underline;">kexi/plugins/reports/kexidbreportdata.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">bool</span> <span class="n">getSchema</span><span class="p">();</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">bool</span> <span class="n">getSchema</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not fixed.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107610/diff/1/?file=97441#file97441line302" style="color: black; font-weight: bold; text-decoration: underline;">kexi/widget/KexiNameWidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">238</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">/*bool KexiNameWidget::eventFilter( QObject *obj, QEvent *ev )</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">302</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">/*bool KexiNameWidget::eventFilter( QObject *obj, QEvent *ev )</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">not fixed</pre>
</div>
<br />
<p>- Jarosław</p>
<br />
<p>On December 9th, 2012, 8:30 a.m., Shou Ya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Shou Ya.</div>
<p style="color: grey;"><i>Updated Dec. 9, 2012, 8:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've done with it for all the classes, please review.
Good luck!
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/migration/importwizard.h <span style="color: grey">(80d0e81)</span></li>
<li>kexi/migration/importwizard.cpp <span style="color: grey">(c0f120f)</span></li>
<li>kexi/migration/keximigrate.h <span style="color: grey">(8b8ce71)</span></li>
<li>kexi/migration/keximigrate.cpp <span style="color: grey">(4e53d2d)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.h <span style="color: grey">(a7dc9d0)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.cpp <span style="color: grey">(cad94c7)</span></li>
<li>kexi/plugins/forms/kexiformview.h <span style="color: grey">(f09aec2)</span></li>
<li>kexi/plugins/forms/kexiformview.cpp <span style="color: grey">(b011808)</span></li>
<li>kexi/plugins/forms/widgets/kexidbform.h <span style="color: grey">(c2e0eca)</span></li>
<li>kexi/plugins/forms/widgets/kexidbform.cpp <span style="color: grey">(c2dd1c5)</span></li>
<li>kexi/plugins/forms/widgets/kexidbutils.h <span style="color: grey">(d02e394)</span></li>
<li>kexi/plugins/forms/widgets/kexidbutils.cpp <span style="color: grey">(9d60a80)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvwidgets.h <span style="color: grey">(12150ed)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvwidgets.cpp <span style="color: grey">(2c6f8c7)</span></li>
<li>kexi/plugins/reports/InternalSourceSelector.h <span style="color: grey">(cb8b0b4)</span></li>
<li>kexi/plugins/reports/kexidbreportdata.h <span style="color: grey">(deb4687)</span></li>
<li>kexi/plugins/reports/kexidbreportdata.cpp <span style="color: grey">(b6f5edb)</span></li>
<li>kexi/plugins/reports/keximigratereportdata.h <span style="color: grey">(e4a88630)</span></li>
<li>kexi/plugins/reports/keximigratereportdata.cpp <span style="color: grey">(cf8abe8)</span></li>
<li>kexi/plugins/reports/kexisourceselector.h <span style="color: grey">(e44e15e)</span></li>
<li>kexi/plugins/reports/kexisourceselector.cpp <span style="color: grey">(808ae5b)</span></li>
<li>kexi/widget/KexiNameDialog.h <span style="color: grey">(429ee8b)</span></li>
<li>kexi/widget/KexiNameDialog.cpp <span style="color: grey">(643fc22)</span></li>
<li>kexi/widget/KexiNameWidget.h <span style="color: grey">(5947a58)</span></li>
<li>kexi/widget/KexiNameWidget.cpp <span style="color: grey">(021bc9f)</span></li>
<li>kexi/widget/KexiProjectSelectorWidget.h <span style="color: grey">(647d8a4)</span></li>
<li>kexi/widget/KexiProjectSelectorWidget.cpp <span style="color: grey">(a8e1f15)</span></li>
<li>kexi/widget/dataviewcommon/KexiTableViewColumn.h <span style="color: grey">(2248c65)</span></li>
<li>kexi/widget/dataviewcommon/KexiTableViewColumn.cpp <span style="color: grey">(14c2c35)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawarepropertyset.h <span style="color: grey">(3a4c576)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp <span style="color: grey">(b7c0043)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.h <span style="color: grey">(600455a)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.cpp <span style="color: grey">(d608958)</span></li>
<li>kexi/widget/fields/KexiFieldListModelItem.h <span style="color: grey">(5486a77)</span></li>
<li>kexi/widget/fields/KexiFieldListModelItem.cpp <span style="color: grey">(fe55b12)</span></li>
<li>kexi/widget/fields/KexiFieldListView.h <span style="color: grey">(1ea94bd)</span></li>
<li>kexi/widget/fields/KexiFieldListView.cpp <span style="color: grey">(bed42a0)</span></li>
<li>kexi/widget/kexicharencodingcombobox.h <span style="color: grey">(74fdfb2)</span></li>
<li>kexi/widget/kexicharencodingcombobox.cpp <span style="color: grey">(4be3315)</span></li>
<li>kexi/widget/kexidbconnectionwidget.h <span style="color: grey">(234235a)</span></li>
<li>kexi/widget/kexidbconnectionwidget.cpp <span style="color: grey">(38cd1a2)</span></li>
<li>kexi/widget/kexidbdrivercombobox.h <span style="color: grey">(8c07307)</span></li>
<li>kexi/widget/kexidbdrivercombobox.cpp <span style="color: grey">(d85fe4a)</span></li>
<li>kexi/widget/kexiscrollview.h <span style="color: grey">(4fc6f85)</span></li>
<li>kexi/widget/kexiscrollview.cpp <span style="color: grey">(5a94228)</span></li>
<li>kexi/widget/kexislider.h <span style="color: grey">(36c2f73)</span></li>
<li>kexi/widget/kexislider.cpp <span style="color: grey">(4545dc8)</span></li>
<li>kexi/widget/navigator/KexiProjectModelItem.h <span style="color: grey">(fe04381)</span></li>
<li>kexi/widget/navigator/KexiProjectModelItem.cpp <span style="color: grey">(764c17a)</span></li>
<li>kexi/widget/navigator/KexiProjectNavigator.h <span style="color: grey">(4f32e31)</span></li>
<li>kexi/widget/navigator/KexiProjectNavigator.cpp <span style="color: grey">(284ef34)</span></li>
<li>kexi/widget/tableview/kexidatatable.h <span style="color: grey">(ca9c22a)</span></li>
<li>kexi/widget/tableview/kexidatatable.cpp <span style="color: grey">(b2d4c74)</span></li>
<li>kexi/widget/utils/KexiDockableWidget.h <span style="color: grey">(23d809d)</span></li>
<li>kexi/widget/utils/KexiDockableWidget.cpp <span style="color: grey">(d1060cb)</span></li>
<li>kexi/widget/utils/kexicomboboxdropdownbutton.h <span style="color: grey">(20957db)</span></li>
<li>kexi/widget/utils/kexicomboboxdropdownbutton.cpp <span style="color: grey">(d724191)</span></li>
<li>kexi/widget/utils/kexidatetimeformatter.h <span style="color: grey">(5d8e9fe)</span></li>
<li>kexi/widget/utils/kexidatetimeformatter.cpp <span style="color: grey">(fed7692)</span></li>
<li>kexi/widget/utils/kexitooltip.h <span style="color: grey">(c0cf3b5)</span></li>
<li>kexi/widget/utils/kexitooltip.cpp <span style="color: grey">(bd2e7c4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107610/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>