<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107610/">http://git.reviewboard.kde.org/r/107610/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107610/diff/1/?file=97426#file97426line125" style="color: black; font-weight: bold; text-decoration: underline;">kexi/migration/importwizard.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">125</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QWidget</span> <span class="o">*</span><span class="n">m_introPageWidget</span><span class="p">,</span> <span class="o">*</span><span class="n">m_srcConnPageWidget</span><span class="p">,</span> <span class="o">*</span><span class="n">m_srcDBPageWidget</span><span class="p">,</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">125</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">class</span> <span class="n">Private</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see Private has been removed from importwizard.h - mistake?</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks like the patch is invalid, e.g. there are no longer changes for KexiMigrate: https://git.reviewboard.kde.org/r/107610/diff/2/#index_header
Please upload diff compared calligra master branch, not compared your recent local commit.</pre>
<p>- Jarosław</p>
<br />
<p>On December 8th, 2012, 4:33 a.m., Shou Ya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Shou Ya.</div>
<p style="color: grey;"><i>Updated Dec. 8, 2012, 4:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've done with it for all the classes, please review.
Good luck!
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/migration/importwizard.cpp <span style="color: grey">(c0f120f)</span></li>
<li>kexi/migration/keximigrate.cpp <span style="color: grey">(4e53d2d)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvwidgets.cpp <span style="color: grey">(2c6f8c7)</span></li>
<li>kexi/plugins/reports/InternalSourceSelector.h <span style="color: grey">(cb8b0b4)</span></li>
<li>kexi/plugins/reports/kexidbreportdata.h <span style="color: grey">(deb4687)</span></li>
<li>kexi/plugins/reports/keximigratereportdata.h <span style="color: grey">(e4a88630)</span></li>
<li>kexi/plugins/reports/keximigratereportdata.cpp <span style="color: grey">(cf8abe8)</span></li>
<li>kexi/plugins/reports/kexisourceselector.h <span style="color: grey">(e44e15e)</span></li>
<li>kexi/plugins/reports/kexisourceselector.cpp <span style="color: grey">(808ae5b)</span></li>
<li>kexi/widget/KexiNameWidget.cpp <span style="color: grey">(021bc9f)</span></li>
<li>kexi/widget/dataviewcommon/KexiTableViewColumn.cpp <span style="color: grey">(14c2c35)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp <span style="color: grey">(b7c0043)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.cpp <span style="color: grey">(d608958)</span></li>
<li>kexi/widget/fields/KexiFieldListModelItem.cpp <span style="color: grey">(fe55b12)</span></li>
<li>kexi/widget/navigator/KexiProjectModelItem.h <span style="color: grey">(fe04381)</span></li>
<li>kexi/widget/navigator/KexiProjectModelItem.cpp <span style="color: grey">(764c17a)</span></li>
<li>kexi/widget/utils/kexidatetimeformatter.cpp <span style="color: grey">(fed7692)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107610/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>