<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107330/">http://git.reviewboard.kde.org/r/107330/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">
- Perhaps it's earlier bug but please look at numbers on the vertical header (it's "2, 2, 3", instead of "1, 2, 3"): http://wstaw.org/m/2012/12/02/plasma-desktoppx2099.png
Test data (autodetected separator is ','):
,"a",,"b"
,,,
,,"c"
"d",
- I am sorry for confusion, after further testing the assistant's buttons, I propose: in 'Importing...' page Next button should be hidden; on the first page Back button should be hidden; Import... button should be visible only when it's available
- On the 'Choose Name of Destination Table' page, if no destination table is selected, "Next" button should be disabled.
- If destination table T was opened prior to importing (appending to T) it could be best if we refresh its contents. For now we can do that by closing and opening the table's window.
- Later check: what to do if we have the destination table T opened in desingn mode and it's 'dirty' (changed)? We have to ask the user about confirmation of dropping the Design before we can continue.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107330/diff/4/?file=97043#file97043line2164" style="color: black; font-weight: bold; text-decoration: underline;">kexi/plugins/importexport/csv/kexicsvimportdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KexiCSVImportDialog::accept()</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KexiCSVImportDialog::import()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1985</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span class="o">~</span><span class="n">res</span> <span class="o">==</span> <span class="o">::</span><span class="n">cancelled</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-> (~res) </pre>
</div>
<br />
<p>- Jarosław</p>
<br />
<p>On December 1st, 2012, 11:59 p.m., Oleg Kukharchuk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.</div>
<div>By Oleg Kukharchuk.</div>
<p style="color: grey;"><i>Updated Dec. 1, 2012, 11:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* moved to a KAssistantDialog
* added ability to import into an existent table</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested on local branch
and additional testing needed
(code was not cleaned up yet)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/importexport/csv/kexicsvimportdialog.h <span style="color: grey">(15be3504dfc54877bc45d81eb7e59a72f70c9c5a)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <span style="color: grey">(5176299599ab034bf256f07ee2651d8a4babb3a0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107330/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>