<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107506/">http://git.reviewboard.kde.org/r/107506/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i agree this seems pointless
please backport too</pre>
<br />
<p>- C.</p>
<br />
<p>On November 28th, 2012, 6:18 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Nov. 28, 2012, 6:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The old code in KoDocumentRdf::emitSemanticObjectUpdated(...) does not make any sense to me, seems to be not cleaned-up code that just does not trigger a bug, only abuses more cycles than needed:
it loops over all xmlids of the item, just to call "insertReflow(col, item);" each time. Now, KoDocumentRdf::insertReflow(...) itself does loop over all xmlids and creates a reflowItem for each, then inserts that to the table/map. Doing this the number of times of xmlids, like happening with the old code, seems useless, as each time besides the first the existing entry in the col map is just overwritten, as findExtent(xmlid) will always return the same for the same xmlid.
Okay to commit to 2.6 and master?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/rdf/KoDocumentRdf.cpp <span style="color: grey">(00bc1bd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107506/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>