<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107495/">http://git.reviewboard.kde.org/r/107495/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 28th, 2012, 8:49 a.m., <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code looks good, I just had a couple of minor issues. What I wonder is if this is tested with LibreOffice and/or OpenOffice.org. Do we have interoperability?</pre>
</blockquote>
<p>On November 28th, 2012, 10:07 a.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just tried and no there is no interperablity. Not sure it's such a common use case to have both suites running simultaniously. Anyway they dont seem to load/save to clipboard using odf. And our html exhange is not very good it would seem
As for your other comments. I've changed them but am not going to upload a new diff just for that</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">They use HTML for cut&paste interchange?
No, there is no need to upload a new diff.</pre>
<br />
<p>- Inge</p>
<br />
<p>On November 27th, 2012, 8:43 p.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2012, 8:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes copy/paste by
1) saving the used styles to clipboard as well
2) only add a style if another style named the same doesn't exist already</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some basic cut and paste with variations of styles applied</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoTextDrag.cpp <span style="color: grey">(9f2d537)</span></li>
<li>libs/kotext/KoTextOdfSaveHelper.h <span style="color: grey">(39107ef)</span></li>
<li>libs/kotext/KoTextOdfSaveHelper.cpp <span style="color: grey">(e01e651)</span></li>
<li>libs/kotext/opendocument/KoTextWriter.cpp <span style="color: grey">(0d52062)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.cpp <span style="color: grey">(4439769)</span></li>
<li>libs/kotext/styles/KoStyleManager.h <span style="color: grey">(ae2e720)</span></li>
<li>libs/kotext/styles/KoStyleManager.cpp <span style="color: grey">(2aa74fe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107495/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>