<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107459/">http://git.reviewboard.kde.org/r/107459/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3beb7ee26781e5fd80b1195032d9c284c8073ba0 by Sujith Haridasan to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 25th, 2012, 4:44 p.m., Sujith Haridasan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Arjen Hiemstra, Boudewijn Rempt, Inge Wallin, and C. Boemann.</div>
<div>By Sujith Haridasan.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2012, 4:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch helps to pass the issue in the http://build.kde.org/job/calligra_master/323/testReport/(root)/TestSuite/sheets_InformationFunctions/ because of which the test case TestInformationFunctions were failing.
The failure is as below:
FAIL! : Calligra::Sheets::TestInformationFunctions::testINFO() Compared values are not the same
Actual (evaluate("ISNUMBER(INFO(\"numfile\"))",z)): Boolean: FALSE
Expected ((z)): Boolean: TRUE
Loc: [/srv/jenkins/workspace/calligra_master/sheets/tests/TestInformationFunctions.cpp(338)]
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I had done testing on my host machine. And here is the output:
sujith@kdekiddo:/media/kdedeveloper/kde-dev/kde/build/KDE/calligra/sheets/tests$ ./TestInformationFunctions
********* Start testing of Calligra::Sheets::TestInformationFunctions *********
Config: Using QTest library 4.8.4, Qt 4.8.4
QDEBUG : Calligra::Sheets::TestInformationFunctions::initTestCase() qttest(27285)/kdecore (KSycoca) KSycocaPrivate::openDatabase: Trying to open ksycoca from "/home/sujith/.kde-unit-test/cache-kdekiddo/ksycoca4"
PASS : Calligra::Sheets::TestInformationFunctions::initTestCase()
PASS : Calligra::Sheets::TestInformationFunctions::testAREAS()
PASS : Calligra::Sheets::TestInformationFunctions::testCELL()
PASS : Calligra::Sheets::TestInformationFunctions::testCOLUMN()
PASS : Calligra::Sheets::TestInformationFunctions::testCOLUMNS()
PASS : Calligra::Sheets::TestInformationFunctions::testCOUNT()
PASS : Calligra::Sheets::TestInformationFunctions::testCOUNTA()
PASS : Calligra::Sheets::TestInformationFunctions::testCOUNTBLANK()
PASS : Calligra::Sheets::TestInformationFunctions::testCOUNTIF()
PASS : Calligra::Sheets::TestInformationFunctions::testERRORTYPE()
PASS : Calligra::Sheets::TestInformationFunctions::testFORMULA()
PASS : Calligra::Sheets::TestInformationFunctions::testINFO()
PASS : Calligra::Sheets::TestInformationFunctions::testISBLANK()
PASS : Calligra::Sheets::TestInformationFunctions::testISERR()
PASS : Calligra::Sheets::TestInformationFunctions::testISERROR()
PASS : Calligra::Sheets::TestInformationFunctions::testISEVEN()
PASS : Calligra::Sheets::TestInformationFunctions::testISFORMULA()
PASS : Calligra::Sheets::TestInformationFunctions::testISLOGICAL()
PASS : Calligra::Sheets::TestInformationFunctions::testISNONTEXT()
PASS : Calligra::Sheets::TestInformationFunctions::testISNA()
PASS : Calligra::Sheets::TestInformationFunctions::testISNUMBER()
PASS : Calligra::Sheets::TestInformationFunctions::testISODD()
PASS : Calligra::Sheets::TestInformationFunctions::testISTEXT()
PASS : Calligra::Sheets::TestInformationFunctions::testISREF()
PASS : Calligra::Sheets::TestInformationFunctions::testMATCH()
PASS : Calligra::Sheets::TestInformationFunctions::testN()
PASS : Calligra::Sheets::TestInformationFunctions::testNA()
PASS : Calligra::Sheets::TestInformationFunctions::testROW()
PASS : Calligra::Sheets::TestInformationFunctions::testROWS()
PASS : Calligra::Sheets::TestInformationFunctions::testSHEET()
PASS : Calligra::Sheets::TestInformationFunctions::testSHEETS()
PASS : Calligra::Sheets::TestInformationFunctions::testTYPE()
PASS : Calligra::Sheets::TestInformationFunctions::testVALUE()
PASS : Calligra::Sheets::TestInformationFunctions::cleanupTestCase()
Totals: 34 passed, 0 failed, 0 skipped
********* Finished testing of Calligra::Sheets::TestInformationFunctions *********
sujith@kdekiddo:/media/kdedeveloper/kde-dev/kde/build/KDE/calligra/sheets/tests$</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/KoApplication.h <span style="color: grey">(b0bcab2)</span></li>
<li>libs/main/KoApplication.cpp <span style="color: grey">(8ac4639)</span></li>
<li>sheets/functions/information.cpp <span style="color: grey">(5ae962d)</span></li>
<li>sheets/tests/TestInformationFunctions.cpp <span style="color: grey">(d0adc68)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107459/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>