<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107410/">http://git.reviewboard.kde.org/r/107410/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Dag</p>
<br />
<p>On November 21st, 2012, 7:37 p.m., Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Dag Andersen.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2012, 7:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch moves the kdgantt library that was previously in the top directory into a subdirectory called 3rdparty/. This was suggested in a discussion on IRC as a way to keep 3rdparty library sources collected in one place.
More importantly it also creates a real dynamically loaded library from it and discards the old method of including the sources wherever the "library" was used. This is specifically in Plan. The reason for doing this is that building Plan totally fails on Windows without this patch.
After this patch is OK'ed and merged, I will continue with KDChart which is now residing inside the chart shape but which is also used in e.g. Kexi.
Many thanks go to Ben Cooksley and Stuart McDickson for testing and difficult bugfixing. CMake is tricky :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stuart has tested on Windows and I on Linux. I'd like Dag to test if Plan works for him with this patch before I merge it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>3rdparty/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/Mainpage.dox <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/docs.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdgantt_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttabstractgrid.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttabstractgrid.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttabstractgrid_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttabstractrowcontroller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttabstractrowcontroller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttconstraint.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttconstraint.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttconstraint_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttconstraintgraphicsitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttconstraintgraphicsitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttconstraintmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttconstraintmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttconstraintmodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttconstraintproxy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttconstraintproxy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttdatetimegrid.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttdatetimegrid.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttdatetimegrid_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttforwardingproxymodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttforwardingproxymodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttglobal.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttglobal.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttgraphicsitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttgraphicsitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttgraphicsscene.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttgraphicsscene.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttgraphicsscene_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttgraphicsview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttgraphicsview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttgraphicsview_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttitemdelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttitemdelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttitemdelegate_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttlegend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttlegend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttlegend_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttlistviewrowcontroller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttlistviewrowcontroller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttlistviewrowcontroller_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttproxymodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttproxymodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttproxymodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttstyleoptionganttitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttstyleoptionganttitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttsummaryhandlingproxymodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttsummaryhandlingproxymodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttsummaryhandlingproxymodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdgantttimescalezoomdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdgantttimescalezoomdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdgantttreeviewrowcontroller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdgantttreeviewrowcontroller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdgantttreeviewrowcontroller_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>3rdparty/kdgantt/kdganttview_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(3ca1f52)</span></li>
<li>kdgantt/CMakeLists.txt <span style="color: grey">(e74903f)</span></li>
<li>kdgantt/Mainpage.dox <span style="color: grey">(4b23dfa)</span></li>
<li>kdgantt/Messages.sh <span style="color: grey">(65aa502)</span></li>
<li>kdgantt/docs.h <span style="color: grey">(3b5b79c)</span></li>
<li>kdgantt/kdgantt_export.h <span style="color: grey">(468cf4b)</span></li>
<li>kdgantt/kdganttabstractgrid.h <span style="color: grey">(5a0be55)</span></li>
<li>kdgantt/kdganttabstractgrid.cpp <span style="color: grey">(9408af8)</span></li>
<li>kdgantt/kdganttabstractgrid_p.h <span style="color: grey">(fb80a12)</span></li>
<li>kdgantt/kdganttabstractrowcontroller.h <span style="color: grey">(a6810cc)</span></li>
<li>kdgantt/kdganttabstractrowcontroller.cpp <span style="color: grey">(b19636f)</span></li>
<li>kdgantt/kdganttconstraint.h <span style="color: grey">(fd65df8)</span></li>
<li>kdgantt/kdganttconstraint.cpp <span style="color: grey">(4c6dab8)</span></li>
<li>kdgantt/kdganttconstraint_p.h <span style="color: grey">(8a216a4)</span></li>
<li>kdgantt/kdganttconstraintgraphicsitem.h <span style="color: grey">(74847bd)</span></li>
<li>kdgantt/kdganttconstraintgraphicsitem.cpp <span style="color: grey">(50445da)</span></li>
<li>kdgantt/kdganttconstraintmodel.h <span style="color: grey">(bc1ed5c)</span></li>
<li>kdgantt/kdganttconstraintmodel.cpp <span style="color: grey">(ea6874dd)</span></li>
<li>kdgantt/kdganttconstraintmodel_p.h <span style="color: grey">(89df082)</span></li>
<li>kdgantt/kdganttconstraintproxy.h <span style="color: grey">(35a15d1)</span></li>
<li>kdgantt/kdganttconstraintproxy.cpp <span style="color: grey">(25cd488)</span></li>
<li>kdgantt/kdganttdatetimegrid.h <span style="color: grey">(4adeb06)</span></li>
<li>kdgantt/kdganttdatetimegrid.cpp <span style="color: grey">(79c405c)</span></li>
<li>kdgantt/kdganttdatetimegrid_p.h <span style="color: grey">(0043e79)</span></li>
<li>kdgantt/kdganttforwardingproxymodel.h <span style="color: grey">(f0a63bb)</span></li>
<li>kdgantt/kdganttforwardingproxymodel.cpp <span style="color: grey">(b38c1aa)</span></li>
<li>kdgantt/kdganttglobal.h <span style="color: grey">(bd88e3d)</span></li>
<li>kdgantt/kdganttglobal.cpp <span style="color: grey">(a76ac62)</span></li>
<li>kdgantt/kdganttgraphicsitem.h <span style="color: grey">(0f73c82)</span></li>
<li>kdgantt/kdganttgraphicsitem.cpp <span style="color: grey">(25103f4)</span></li>
<li>kdgantt/kdganttgraphicsscene.h <span style="color: grey">(516cd0c)</span></li>
<li>kdgantt/kdganttgraphicsscene.cpp <span style="color: grey">(1d6f181)</span></li>
<li>kdgantt/kdganttgraphicsscene_p.h <span style="color: grey">(e421b7f)</span></li>
<li>kdgantt/kdganttgraphicsview.h <span style="color: grey">(1701a9b)</span></li>
<li>kdgantt/kdganttgraphicsview.cpp <span style="color: grey">(fd07889)</span></li>
<li>kdgantt/kdganttgraphicsview_p.h <span style="color: grey">(fd20baf)</span></li>
<li>kdgantt/kdganttitemdelegate.h <span style="color: grey">(daeb16d)</span></li>
<li>kdgantt/kdganttitemdelegate.cpp <span style="color: grey">(1e08b04)</span></li>
<li>kdgantt/kdganttitemdelegate_p.h <span style="color: grey">(87da262)</span></li>
<li>kdgantt/kdganttlegend.h <span style="color: grey">(4ccdb4c)</span></li>
<li>kdgantt/kdganttlegend.cpp <span style="color: grey">(3f1e089)</span></li>
<li>kdgantt/kdganttlegend_p.h <span style="color: grey">(e5dbf25)</span></li>
<li>kdgantt/kdganttlistviewrowcontroller.h <span style="color: grey">(23c9c92)</span></li>
<li>kdgantt/kdganttlistviewrowcontroller.cpp <span style="color: grey">(792c7c5)</span></li>
<li>kdgantt/kdganttlistviewrowcontroller_p.h <span style="color: grey">(302814d)</span></li>
<li>kdgantt/kdganttproxymodel.h <span style="color: grey">(ce95dce)</span></li>
<li>kdgantt/kdganttproxymodel.cpp <span style="color: grey">(0351ad0)</span></li>
<li>kdgantt/kdganttproxymodel_p.h <span style="color: grey">(d127984)</span></li>
<li>kdgantt/kdganttstyleoptionganttitem.h <span style="color: grey">(21ecef1)</span></li>
<li>kdgantt/kdganttstyleoptionganttitem.cpp <span style="color: grey">(e1985e6)</span></li>
<li>kdgantt/kdganttsummaryhandlingproxymodel.h <span style="color: grey">(05e0614)</span></li>
<li>kdgantt/kdganttsummaryhandlingproxymodel.cpp <span style="color: grey">(43f5cbc)</span></li>
<li>kdgantt/kdganttsummaryhandlingproxymodel_p.h <span style="color: grey">(0f1d7ea)</span></li>
<li>kdgantt/kdgantttimescalezoomdialog.h <span style="color: grey">(fbcef67)</span></li>
<li>kdgantt/kdgantttimescalezoomdialog.cpp <span style="color: grey">(86fcb32)</span></li>
<li>kdgantt/kdgantttreeviewrowcontroller.h <span style="color: grey">(0a1251e)</span></li>
<li>kdgantt/kdgantttreeviewrowcontroller.cpp <span style="color: grey">(b9b2045)</span></li>
<li>kdgantt/kdgantttreeviewrowcontroller_p.h <span style="color: grey">(c76b902)</span></li>
<li>kdgantt/kdganttview.h <span style="color: grey">(c61d47c)</span></li>
<li>kdgantt/kdganttview.cpp <span style="color: grey">(a09edf1)</span></li>
<li>kdgantt/kdganttview_p.h <span style="color: grey">(f47b57b)</span></li>
<li>plan/CMakeLists.txt <span style="color: grey">(0d96065)</span></li>
<li>plan/libs/models/CMakeLists.txt <span style="color: grey">(86e08ba)</span></li>
<li>plan/libs/ui/CMakeLists.txt <span style="color: grey">(e22e4dc)</span></li>
<li>plan/workpackage/CMakeLists.txt <span style="color: grey">(1b60b99)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(ab8151b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107410/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>