<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107370/">http://git.reviewboard.kde.org/r/107370/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 218501ec0afa5dca6d0c270fa32a455f8cf135e4 by Friedrich W. H. Kossebau to branch calligra/2.6.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 18th, 2012, 2:37 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and C. Boemann.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Nov. 18, 2012, 2:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let's use some additional and easily fetched data for the default Author profile, if existing.
The KEmailSettings data is also used by KBugReport and KToolInvocation, so chances are high that there is some useful data (entered by at least the SystemSettings/Account Detail).
The phone number details in KUser might exist perhaps in LDAP-based settings, where chances are high the gecos field gets filled with existing data. Well, two additional lines which might not hurt that much to anyone else.
It could also be an idea to use the addressbook and look for the self-contact, but sadly there is no standardized interface to a system addressbook yet. And checking for Akonadi, EDS and whatever else there might be is quite some code, no interest for that by myself ;)
Backport to 2.6?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/KoDocumentInfo.cpp <span style="color: grey">(77b5992)</span></li>
<li>libs/main/config/KoConfigAuthorPage.cpp <span style="color: grey">(2e55f9f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107370/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>