<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107068/">http://git.reviewboard.kde.org/r/107068/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg, Dimitrios Tanis, Radosław Wicik, and Oleg Kukharchuk.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2012, 8:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As proposed by Dimitrios:
- display different the warning
- while user is editing, hide the warning if overflow is fixed
- upon saving, trim if needed
Also:
- the warning now informs how many characters would be trimmed (so is updated on every editing action)
- refactored code displaying warning messages to avoid duplicates</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tables/Forms: show indication that edited or pasted text is trimmed.
See also http://forum.kde.org/viewtopic.php?f=221&t=102475 thread.
Screencasts with the feature:
http://www.youtube.com/watch?v=Qdd7CaBonq0
http://www.youtube.com/watch?v=wjyGsWxnAEs
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Properly displays warnings and trims data</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=301136">301136</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/core/kexidataiteminterface.h <span style="color: grey">(639e875)</span></li>
<li>kexi/core/kexidataiteminterface.cpp <span style="color: grey">(8eb9d4d)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.h <span style="color: grey">(43ce3f9)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.cpp <span style="color: grey">(9ba0fc4)</span></li>
<li>kexi/plugins/forms/widgets/kexidblineedit.h <span style="color: grey">(faf954b)</span></li>
<li>kexi/plugins/forms/widgets/kexidblineedit.cpp <span style="color: grey">(f023937)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.h <span style="color: grey">(ef5a892)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp <span style="color: grey">(ba5266c)</span></li>
<li>kexi/widget/tableview/kexiinputtableedit.h <span style="color: grey">(fe20fb1)</span></li>
<li>kexi/widget/tableview/kexiinputtableedit.cpp <span style="color: grey">(8c62a28)</span></li>
<li>kexi/widget/tableview/kexitableview.h <span style="color: grey">(e01ba05)</span></li>
<li>kexi/widget/tableview/kexitableview.cpp <span style="color: grey">(a0e17c6)</span></li>
<li>kexi/widget/tableview/kexitextformatter.h <span style="color: grey">(880a36c)</span></li>
<li>kexi/widget/tableview/kexitextformatter.cpp <span style="color: grey">(c119056)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107068/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>