<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107229/">http://git.reviewboard.kde.org/r/107229/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 6th, 2012, 6:04 p.m., <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107229/diff/1/?file=93886#file93886line707" style="color: black; font-weight: bold; text-decoration: underline;">plugins/textediting/autocorrection/Autocorrect.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Autocorrect::readAutocorrectXmlEntry()</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Autocorrect::readAutocorrectXmlEntries()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">705</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">break</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">706</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">readAutocorrectXmlEntry</span><span class="p">(</span><span class="n">fname</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You never breaks here ?
So you will read a lot of file no ?</pre>
</blockquote>
<p>On November 6th, 2012, 6:32 p.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes that is the point - I want to first read the general kde wide file and then the calligra specific file.
I could also revert your original patch and just read the calligra one
the point is we need af file with the calligra specifics</pre>
</blockquote>
<p>On November 6th, 2012, 6:48 p.m., <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"The special tags in the calligra supplied config files where never found" which special tags?
global file and calligra file is the same (installed from l10n) So What is the problem ?</pre>
</blockquote>
<p>On November 6th, 2012, 7 p.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Uhm it's not the same file. It may be so in kde 4.9 onwards or so but we should be compatible with kde 4.5
but calligra needs special tags that I for one don't have in my .kde/share/apps/autocorrect/* file</pre>
</blockquote>
<p>On November 6th, 2012, 7:22 p.m., <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand because it's installed from same file from l10n...
So what is missing tag ?</pre>
</blockquote>
<p>On November 6th, 2012, 7:46 p.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">for example:
<SuperScript>
<superscript find="1st" super="st" />
<superscript find="2nd" super="nd" />
<superscript find="3rd" super="rd" />
<superscript find="othernb" super="th" />
</SuperScript>
</pre>
</blockquote>
<p>On November 7th, 2012, 6:50 a.m., <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Error is not that file changed, it's that we don't store it.
When I looked at calligra code there was not save code => you didn't save it.
=> I added it, and missing to add this part.
I will create a patch for it.
(it's right I don't use it in kmail => I didn't see that it was missing)
Will fix it soon.
When you added this plugins to calligra (don't know who) rewrite it and forgot to add write code...</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I fixed save superscript in kmail and calligra
regards</pre>
<br />
<p>- Laurent</p>
<br />
<p>On November 6th, 2012, 5:54 p.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Laurent Montel.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2012, 5:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The special tags in the calligra supplied config files where never found
So I've changed it so we first look up the general files and then the calligra specific files on top
A problem I see is that the general contents is never really used with my approach if we afterwards find a calligra special file
So a better suggestion is appreciated</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/textediting/autocorrection/Autocorrect.h <span style="color: grey">(5b76121)</span></li>
<li>plugins/textediting/autocorrection/Autocorrect.cpp <span style="color: grey">(53fdee6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107229/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>