<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107068/">http://git.reviewboard.kde.org/r/107068/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 29th, 2012, 12:56 a.m., <b>Dimitrios Tanis</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107068/diff/1/?file=92482#file92482line169" style="color: black; font-weight: bold; text-decoration: underline;">kexi/plugins/forms/widgets/kexidblineedit.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KexiDBLineEdit::slotTextEdited(const QString& text)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">169</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setText</span><span class="p">(</span><span class="n">text</span><span class="p">.</span><span class="n">left</span><span class="p">(</span><span class="n">field</span><span class="p">()</span><span class="o">-></span><span class="n">maxLength</span><span class="p">()));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since we no longer rely on maxLength directly to restrict overflowed text, wouldn't it be better to have text overflow UNTIL we choose to save the record? That could allow for pasting field data longer than maxLength set and give the user a chance to do the trim. If he just saves the record, let Kexi handle it. That could save the user some akward trimmings eg. cutting in the middle of a word or sentence. In that context the warning would read "Text WILL be truncated to xxx characters UPON SAVING THE RECORD because of limit for "yyy" field"</pre>
</blockquote>
<p>On October 29th, 2012, 11:30 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dimitrios, that's good idea, thanks.
How about:
- displaying the warning as before with text you proposed
- while user is editing, hide the warning if overflow is fixed (optionally, display info message "Fixed, no trimming needed" in place of the warning, for a while)
- upon saving, trim if needed
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems OK.
Only one note: I was thinking not to have any message when overflow is fixed. Just display the message as long as we have overflowed text. If the user fixes it just close it. Much like e.g. the date error message, we don't inform the user that he entered a correct date after he changes it.</pre>
<br />
<p>- Dimitrios</p>
<br />
<p>On October 27th, 2012, 7:41 a.m., Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg, Dimitrios Tanis, Radosław Wicik, and Oleg Kukharchuk.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2012, 7:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tables/Forms: show indication that edited or pasted text is trimmed.
See also http://forum.kde.org/viewtopic.php?f=221&t=102475 thread.
Screencasts with the feature:
http://www.youtube.com/watch?v=Qdd7CaBonq0
http://www.youtube.com/watch?v=wjyGsWxnAEs
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Properly displays warnings and trims data</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=301136">301136</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/core/kexidataiteminterface.h <span style="color: grey">(639e8758c82121b9a6998ba6c719bd1d97a3f910)</span></li>
<li>kexi/core/kexidataiteminterface.cpp <span style="color: grey">(8eb9d4dfe60b666f0528ffc45b6471520533b765)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.h <span style="color: grey">(43ce3f9aabab8197086c3c3c7658fc51362d9c7f)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.cpp <span style="color: grey">(9ba0fc442fa28534768b36c81c4551e5b8e3cb3f)</span></li>
<li>kexi/plugins/forms/widgets/kexidblineedit.h <span style="color: grey">(fbf686a2c72bf2d7fdf703b9e03d3eaa96ab3147)</span></li>
<li>kexi/plugins/forms/widgets/kexidblineedit.cpp <span style="color: grey">(e1e3f771e3256178c174591f3af6453729c69325)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.h <span style="color: grey">(ef5a892fb371263787fd03ca5884ec3f165cbd2d)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp <span style="color: grey">(ba5266c50024349a4606312e916f9b94a59b2e59)</span></li>
<li>kexi/widget/tableview/kexiinputtableedit.h <span style="color: grey">(fe20fb1a46298371905f1eb9672484417f28fc81)</span></li>
<li>kexi/widget/tableview/kexiinputtableedit.cpp <span style="color: grey">(8c62a289d1752ce2464179de1f5155869dea01bd)</span></li>
<li>kexi/widget/tableview/kexitableview.h <span style="color: grey">(e01ba05c4340e5d7f8fbb409c01c6cdd0c9b7630)</span></li>
<li>kexi/widget/tableview/kexitableview.cpp <span style="color: grey">(a0e17c6c1069d3d7fd1a0c3893a2fd5f6591330e)</span></li>
<li>kexi/widget/tableview/kexitextformatter.h <span style="color: grey">(880a36c9e3702ccdb48ffbf5fb92759b4d0be5b7)</span></li>
<li>kexi/widget/tableview/kexitextformatter.cpp <span style="color: grey">(c119056e63815c0eb4220efb389c5cd1352a79cc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107068/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>