<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105883/">http://git.reviewboard.kde.org/r/105883/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 88b5f7af76326eea734b6c0cdd371982198c3d1f by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 27th, 2012, 3:18 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Jarosław Staniek, Boudewijn Rempt, Thorsten Zachmann, and Inge Wallin.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2012, 3:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Triggered by "Fix loading of VectorShape and KoUnavailShape." (https://git.reviewboard.kde.org/r/105873/) I had another look at the mimetype and detection of SVM files. And found e.g. these, among a lot of similar matches:
* http://api.libreoffice.org/common/ref/com/sun/star/graphic/MediaProperties.html
* https://svn.apache.org/repos/asf/incubator/ooo/trunk/main/filter/source/config/fragments/types/svm_StarView_Metafile.xcu
So it seems that "image/x-svm" is the internally used mimetype string, not "application/x-svm". While that one is not used in the manifest by LO (correctly, as I understood the package spec), Calligra better still should switch to use it internally as well.
And installing the magic data about SVM into the mimetype database will result both in KoOdfLoadingContext::mimeTypeForPath(const QString& path, bool guess) with guess=true delivering the proper mimetype (no longer application/octet-stream), as well as allow to use the mimetype also in the filedialogs to chose a file for the vector shape.
Also moved all three checks for SharedMimeInfo into toplevel CMakeList.txt, made it optional, and adopted the buildsystem:
* have Krita depend on sharedmimeinfo as before (needed for ORA as default format)
* have all ooxml import filters depend on sharedmimeinfo (otherwise formats are not detected/supported at run-time)
* still build the vectorshape plugin, just skip if needed installing SVM info mimetype database,
not perfect, but would need to make SVM support optionally inside vectorshape plugin, which mainly is for EMF/WMF,
but the extra code/work/complexity needed for that extremely rare case IMHO is not worth it
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9840855)</span></li>
<li>filters/CMakeLists.txt <span style="color: grey">(633cdf7)</span></li>
<li>filters/libmsooxml/CMakeLists.txt <span style="color: grey">(af28c28)</span></li>
<li>filters/sheets/CMakeLists.txt <span style="color: grey">(fac2a4f)</span></li>
<li>filters/stage/CMakeLists.txt <span style="color: grey">(6f81f3d)</span></li>
<li>filters/words/CMakeLists.txt <span style="color: grey">(9127e37)</span></li>
<li>krita/plugins/formats/ora/CMakeLists.txt <span style="color: grey">(bb0baad)</span></li>
<li>plugins/vectorshape/CMakeLists.txt <span style="color: grey">(fe677e5)</span></li>
<li>plugins/vectorshape/VectorShape.cpp <span style="color: grey">(232402a)</span></li>
<li>plugins/vectorshape/VectorShapeConfigWidget.cpp <span style="color: grey">(ca9f743)</span></li>
<li>plugins/vectorshape/VectorShapeFactory.cpp <span style="color: grey">(8ead482)</span></li>
<li>plugins/vectorshape/VectorTool.cpp <span style="color: grey">(f0add41)</span></li>
<li>plugins/vectorshape/calligra_svm.xml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105883/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>