<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106756/">http://git.reviewboard.kde.org/r/106756/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 7th, 2012, 4:22 p.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First of all thanks for working on the videoshape - it's been my intention for ages to do some of what you have done.
The d-pointer'fication is not nessesary for plugins, but it cannot hurt either :)
My biggest concern is the change/implementation of the mousepress. This breaks moel/view, and I think we should find some other way to do this. Not quite sure how but let's brainstorm with zagge as well.
Other than that I found a few small issues</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dropped the play within shape part of the patch.</pre>
<br />
<p>- Gopalakrishna</p>
<br />
<p>On October 7th, 2012, 3:56 p.m., Gopalakrishna Bhat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Gopalakrishna Bhat.</div>
<p style="color: grey;"><i>Updated Oct. 7, 2012, 3:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add the following enhancements to videoshape
1) Enable videoshape in Words
2) Add playback controls to Video playback(Volume Control, Playback seeker)
3) Ability to save video within ODF documents.
4) Ability to change video of a video shape
5) Ability to play video in Words/Author by clicking on the play icon(inside the shape at the center).
6) Thumbnails for videoshape
The thumbnail functionality is implemented but untested and hence #ifd out. The reason for this is that the Phonon::VideoWidget::snapshot() functionality is not implemented in the gstreamer backend(the one that I have). I have posted a related mail [1] to phonon-backends ml regarding this.
[1] http://mail.kde.org/pipermail/phonon-backends/2012-October/000711.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoShape.h <span style="color: grey">(77a630c)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(cdb0c6d)</span></li>
<li>libs/flake/KoToolProxy.cpp <span style="color: grey">(375f1e3)</span></li>
<li>plugins/videoshape/CMakeLists.txt <span style="color: grey">(f4d81b6)</span></li>
<li>plugins/videoshape/ChangeVideoCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/videoshape/ChangeVideoCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/videoshape/FullScreenPlayer.h <span style="color: grey">(aee2f90)</span></li>
<li>plugins/videoshape/FullScreenPlayer.cpp <span style="color: grey">(a0faa5c)</span></li>
<li>plugins/videoshape/Plugin.cpp <span style="color: grey">(39c38f0)</span></li>
<li>plugins/videoshape/SelectVideoWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/videoshape/SelectVideoWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/videoshape/VideoCollection.h <span style="color: grey">(f5ece64)</span></li>
<li>plugins/videoshape/VideoCollection.cpp <span style="color: grey">(91c8a2d)</span></li>
<li>plugins/videoshape/VideoData.h <span style="color: grey">(7bd7b7a)</span></li>
<li>plugins/videoshape/VideoData.cpp <span style="color: grey">(b5f4699)</span></li>
<li>plugins/videoshape/VideoShape.h <span style="color: grey">(e9e65da)</span></li>
<li>plugins/videoshape/VideoShape.cpp <span style="color: grey">(32744ab)</span></li>
<li>plugins/videoshape/VideoShapeConfigWidget.h <span style="color: grey">(251dc75)</span></li>
<li>plugins/videoshape/VideoShapeConfigWidget.cpp <span style="color: grey">(4f5d22e)</span></li>
<li>plugins/videoshape/VideoThumbnail.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/videoshape/VideoThumbnail.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/videoshape/VideoTool.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/videoshape/VideoTool.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/videoshape/VideoToolFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/videoshape/VideoToolFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/videoshape/forms/VideoToolWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/wordsrc <span style="color: grey">(3b3c543)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106756/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>