<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106726/">http://git.reviewboard.kde.org/r/106726/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6e43601ab185afbbab8d18e78bf73214a17c3e64 by Jaroslaw Staniek to branch calligra/2.5.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 4th, 2012, 9:32 p.m., Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Oct. 4, 2012, 9:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix the lowercase fix and db import
KexiDB
*A fix for the lowercase fix: keep table names in original format but compare them in case-insensitive way when needed
**This way importing from databases with tables upper-case characters works
Migration
*Fix invalid SQL generation for database import
*Fix importing from databases with tables upper-case characters
Details: premature converting table names to lower-case leads to issues when user had upper-case letters in names. Kexi now prevents uppercase letters via the GUI only, without any special cases while importing. This will also help in future expansion to 'attach/link to a non-kexi DBs' feature.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">importing and usual db operations tested</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=306523">306523</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=307479">307479</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/core/kexiproject.cpp <span style="color: grey">(1a7b962749db910d5c04d4690b352fb5b9baba4e)</span></li>
<li>kexi/migration/keximigrate.cpp <span style="color: grey">(75b84d59efa21ab84da9ec77971d4285fb61752a)</span></li>
<li>kexi/migration/mysql/mysqlmigrate.cpp <span style="color: grey">(0fb0d47b914fc4d5ef802c583f83de0aa784c7a0)</span></li>
<li>libs/db/connection.cpp <span style="color: grey">(d36def0c1b66440c79fa617bc185b47cf2d67d06)</span></li>
<li>libs/db/expression.cpp <span style="color: grey">(77f4fa93b4fd8bfc49ffdb12e8b205b5d0b34a3c)</span></li>
<li>libs/db/tableschema.cpp <span style="color: grey">(8bf2eeca75c792b9a78c626dd4aeb6893784413b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106726/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>