<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106724/">http://git.reviewboard.kde.org/r/106724/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Lukáš Tvrdý.</div>
<div>By Dmitry Kazakov.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi!
This patch adds caching of the dabs to the paint op system of Krita. Such cache makes the execution of the benchmarks up to 2 times faster. Subjectively, the real painting becomes much faster, especially with huge brushes.
Of course, such caching makes the painting a bit less precise: we need to tolerate subpixel differences to allow the cache to work. Sometimes small difference in the size of a dab can also be acceptable. That is why I introduced levels of precision. They are graded from 1 to 5: from the fastest and less precise to the slowest, but with the best quality. You can see the slider in the paintop settings dialog. The ToolTip text explains which features of the brush are sacrificed on each precision level.
The texturing and mirroring problems are solved.
My next steps are: make this cache tolerate bug 307588 and port it to other brush-based paitops.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/image/kis_fixed_paint_device.h <span style="color: grey">(feeed0b)</span></li>
<li>krita/image/kis_fixed_paint_device.cpp <span style="color: grey">(5ef55af)</span></li>
<li>krita/image/kis_painter.h <span style="color: grey">(25a11c9)</span></li>
<li>krita/image/kis_painter.cc <span style="color: grey">(bec3776)</span></li>
<li>krita/plugins/paintops/defaultpaintops/brush/kis_brushop.h <span style="color: grey">(1b545ef)</span></li>
<li>krita/plugins/paintops/defaultpaintops/brush/kis_brushop.cpp <span style="color: grey">(177fa7e)</span></li>
<li>krita/plugins/paintops/defaultpaintops/brush/kis_brushop_settings_widget.cpp <span style="color: grey">(cbd6667)</span></li>
<li>krita/plugins/paintops/libpaintop/CMakeLists.txt <span style="color: grey">(bd1b021)</span></li>
<li>krita/plugins/paintops/libpaintop/forms/wdgbrushchooser.ui <span style="color: grey">(b19828f)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_brush_based_paintop_options_widget.h <span style="color: grey">(734df21)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_brush_based_paintop_options_widget.cpp <span style="color: grey">(51cc2d2)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_brush_option_widget.h <span style="color: grey">(cf426cb)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_brush_option_widget.cpp <span style="color: grey">(c0e171e)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_brush_selection_widget.h <span style="color: grey">(d25729f)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_brush_selection_widget.cpp <span style="color: grey">(e0bedd8)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_dab_cache.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_dab_cache.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_precision_option.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_precision_option.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_pressure_sharpness_option.h <span style="color: grey">(8281da4)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_pressure_sharpness_option.cpp <span style="color: grey">(6157e5e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106724/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>