<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106633/">http://git.reviewboard.kde.org/r/106633/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If nobody else has any comments this goes in tonight.</pre>
<br />
<p>- Inge</p>
<br />
<p>On September 29th, 2012, 6 p.m., Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2012, 6 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fulfills a very old wish of ours, namely the separation of the stroke/fill docker into a widget and an embedding docker. This makes the stroke/fill widget reusable in other places, e.g. a style manager for graphic styles.
I have tried to make the user experience exactly the same as for the old version even though there are lots of misfeatures with it. Improving the user experience will come as future patches, and I don't want to do that without discussing it with other people.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extensive manual testing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/dockers/CMakeLists.txt <span style="color: grey">(c9b4f44)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.h <span style="color: grey">(b0301e6)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.cpp <span style="color: grey">(376ffef)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106633/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>