<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106714/">http://git.reviewboard.kde.org/r/106714/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 3rd, 2012, 4:51 p.m., <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me, but I haven't tested it yet. (I have to admit I haven't tested activities yet :-(</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is mostly about the event reporting, works even without having any activities.
There are two ways to test:
1. Watch for the (delayed) updates to the .kde/share/apps/activitymanager/resources/database (an sqlite3 database)
2. Get the share-like-connect applet
I'll add plasma team to the review - they can help testing.</pre>
<br />
<p>- Ivan</p>
<br />
<p>On October 3rd, 2012, 5:12 p.m., Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Plasma.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2012, 5:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Calligra applications report the open/close document events to activity manager daemon.
Side-effect - support for Share-Like-Connect applet.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with flow, words and krita.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(04d35c3)</span></li>
<li>KoConfig.h.cmake <span style="color: grey">(02f40c3)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(3653de2)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(8eb8dff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106714/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106714/s/753/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/03/calligra-slc_400x100.png" style="border: 1px black solid;" alt="SLC" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>