<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106306/">http://git.reviewboard.kde.org/r/106306/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On September 1st, 2012, 3:27 p.m., Yuri Chornoivan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Marijn Kruisselbrink.</div>
<div>By Yuri Chornoivan.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2012, 3:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sheets script plugins load translation from krossmodulekspread.po but translation catalog is named as krossmoduletables.pot.
Most of the scripts contain references to non-existing www.calligra.org/kspread and KSpread window, etc.
Hope this patch fixes some of these issues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on current git. Not all translations are loaded due to incomplete localization of scripting module (T = Kross.module("kdetranslation") + T.i18n("message") are not used & some troubles with loading plugin names). But Calligra Sheets menu shows much more translated than before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sheets/plugins/scripting/CMakeLists.txt <span style="color: grey">(9b7f610)</span></li>
<li>sheets/plugins/scripting/Messages.sh <span style="color: grey">(003b418)</span></li>
<li>sheets/plugins/scripting/ScriptingPart.cpp <span style="color: grey">(ebcaa09)</span></li>
<li>sheets/plugins/scripting/krossmodulekspread.desktop <span style="color: grey">(739609a)</span></li>
<li>sheets/plugins/scripting/krossmodulesheets.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>sheets/plugins/scripting/scripting.rc <span style="color: grey">(53622b2)</span></li>
<li>sheets/plugins/scripting/scripts/consoledocker.py <span style="color: grey">(1b10d89)</span></li>
<li>sheets/plugins/scripting/scripts/csvexport.py <span style="color: grey">(38ccc71)</span></li>
<li>sheets/plugins/scripting/scripts/csvimport.py <span style="color: grey">(ff15c16)</span></li>
<li>sheets/plugins/scripting/scripts/functions.py <span style="color: grey">(a5013c2)</span></li>
<li>sheets/plugins/scripting/scripts/htmlexport.py <span style="color: grey">(63ec950)</span></li>
<li>sheets/plugins/scripting/scripts/kexidbexport.py <span style="color: grey">(30a3f73)</span></li>
<li>sheets/plugins/scripting/scripts/kexidbimport.py <span style="color: grey">(17d2338)</span></li>
<li>sheets/plugins/scripting/scripts/odfpyexport.py <span style="color: grey">(d0ac37a)</span></li>
<li>sheets/plugins/scripting/scripts/rpyfunctions.py <span style="color: grey">(199e66b)</span></li>
<li>sheets/plugins/scripting/scripts/vcardimport.py <span style="color: grey">(746b0d9)</span></li>
<li>sheets/plugins/scripting/scripts/xmlviewer.py <span style="color: grey">(bfa9a8c)</span></li>
<li>sheets/plugins/scripting/scripts/yfinance.py <span style="color: grey">(a5ee11c)</span></li>
<li>sheets/plugins/scripting/scripts/yweather.py <span style="color: grey">(702e6ca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106306/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>