<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106453/">http://git.reviewboard.kde.org/r/106453/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e0df8022d9c4cd104fe489718f86962f52ea58d5 by Yuri Chornoivan to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 17th, 2012, 10:58 a.m., Yuri Chornoivan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Marijn Kruisselbrink.</div>
<div>By Yuri Chornoivan.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2012, 10:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now all the windows and messages of Sheets scripts cannot be extracted and translated.
This patch should solve the problem for some Python scripts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on all unbroken scripts. Works fine, messages are shown translated as expected.
Broken scripts (htmlexport.py, odfpyexport.py and xmlviewer.py) were not tested as they cannot be run with current version of Sheets without fixing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sheets/plugins/scripting/Messages.sh <span style="color: grey">(003b418)</span></li>
<li>sheets/plugins/scripting/scripts/consoledocker.py <span style="color: grey">(1b10d89)</span></li>
<li>sheets/plugins/scripting/scripts/csvexport.py <span style="color: grey">(38ccc71)</span></li>
<li>sheets/plugins/scripting/scripts/csvimport.py <span style="color: grey">(ff15c16)</span></li>
<li>sheets/plugins/scripting/scripts/functions.py <span style="color: grey">(a5013c2)</span></li>
<li>sheets/plugins/scripting/scripts/htmlexport.py <span style="color: grey">(63ec950)</span></li>
<li>sheets/plugins/scripting/scripts/kexidbexport.py <span style="color: grey">(30a3f73)</span></li>
<li>sheets/plugins/scripting/scripts/kexidbimport.py <span style="color: grey">(17d2338)</span></li>
<li>sheets/plugins/scripting/scripts/logger.py <span style="color: grey">(3918c85)</span></li>
<li>sheets/plugins/scripting/scripts/myorca.py <span style="color: grey">(a698add)</span></li>
<li>sheets/plugins/scripting/scripts/odfpyexport.py <span style="color: grey">(d0ac37a)</span></li>
<li>sheets/plugins/scripting/scripts/pyregexp.py <span style="color: grey">(81ecebd)</span></li>
<li>sheets/plugins/scripting/scripts/pytime.py <span style="color: grey">(0441676)</span></li>
<li>sheets/plugins/scripting/scripts/rpyfunctions.py <span style="color: grey">(199e66b)</span></li>
<li>sheets/plugins/scripting/scripts/vcardimport.py <span style="color: grey">(746b0d9)</span></li>
<li>sheets/plugins/scripting/scripts/xmlviewer.py <span style="color: grey">(bfa9a8c)</span></li>
<li>sheets/plugins/scripting/scripts/yfinance.py <span style="color: grey">(a5ee11c)</span></li>
<li>sheets/plugins/scripting/scripts/yweather.py <span style="color: grey">(702e6ca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106453/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>