<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106559/">http://git.reviewboard.kde.org/r/106559/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit fc777973296e179d2bff4fae8e7d5d878b543b7d by C. Boemann to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 26th, 2012, 7:12 a.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Thorsten Zachmann.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2012, 7:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've changed KoTextBlockData from being stored directly in QtextBlock::userData to storing it's private class
The usage of the class has also changed slightly. Now the class stores itself (well it's private class) on the block
KoTextBlockData itself has become a use-and-throw-away class. It takes care of storing itself on the block</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So far only basic usage of Words. And I have several other commits that use it so I'm fairly sure the idea works. Have no tried Stage and in particular the new animation stuff </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoTextBlockData.h <span style="color: grey">(50baba9)</span></li>
<li>libs/kotext/KoTextBlockData.cpp <span style="color: grey">(9f7062e)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(d8c6908)</span></li>
<li>libs/textlayout/KoTextLayoutArea.h <span style="color: grey">(096e7f1)</span></li>
<li>libs/textlayout/KoTextLayoutArea.cpp <span style="color: grey">(4476f77)</span></li>
<li>libs/textlayout/KoTextLayoutArea_paint.cpp <span style="color: grey">(db08f67)</span></li>
<li>libs/textlayout/ListItemsHelper.cpp <span style="color: grey">(0c32981)</span></li>
<li>stage/part/KPrShapeAnimations.cpp <span style="color: grey">(aa7f11a)</span></li>
<li>stage/part/animations/KPrAnimSet.cpp <span style="color: grey">(bdbd838)</span></li>
<li>stage/part/animations/KPrAnimateMotion.cpp <span style="color: grey">(5ae90d7)</span></li>
<li>stage/part/animations/KPrAnimationBase.cpp <span style="color: grey">(2afcd29)</span></li>
<li>stage/part/animations/KPrAnimationCache.h <span style="color: grey">(ea28d5e)</span></li>
<li>stage/part/animations/KPrAnimationCache.cpp <span style="color: grey">(bfe2380)</span></li>
<li>stage/part/animations/KPrAnimationLoader.cpp <span style="color: grey">(6bea7f5)</span></li>
<li>stage/part/animations/KPrShapeAnimation.h <span style="color: grey">(8ce5d5d)</span></li>
<li>stage/part/animations/KPrShapeAnimation.cpp <span style="color: grey">(505768d)</span></li>
<li>stage/part/animations/KPrTextBlockPaintStrategy.h <span style="color: grey">(13a8c22)</span></li>
<li>stage/part/animations/KPrTextBlockPaintStrategy.cpp <span style="color: grey">(3cf8fe6)</span></li>
<li>stage/part/animations/strategy/KPrAnimationValue.h <span style="color: grey">(493242b)</span></li>
<li>stage/part/animations/strategy/KPrAnimationValue.cpp <span style="color: grey">(36670d3)</span></li>
<li>stage/part/animations/strategy/KPrAttributeHeight.cpp <span style="color: grey">(03bcf82)</span></li>
<li>stage/part/animations/strategy/KPrAttributeRotate.cpp <span style="color: grey">(f33374a)</span></li>
<li>stage/part/animations/strategy/KPrAttributeWidth.cpp <span style="color: grey">(8b4d07f)</span></li>
<li>stage/part/animations/strategy/KPrAttributeX.cpp <span style="color: grey">(b56e4a3)</span></li>
<li>stage/part/animations/strategy/KPrAttributeY.cpp <span style="color: grey">(c2a5b6e)</span></li>
<li>stage/part/animations/strategy/KPrFormulaParser.h <span style="color: grey">(e0ddb0f)</span></li>
<li>stage/part/animations/strategy/KPrFormulaParser.cpp <span style="color: grey">(f12e829)</span></li>
<li>stage/part/tests/MockShapeAnimation.h <span style="color: grey">(2a98d38)</span></li>
<li>stage/part/tests/TestShapeAnimations.cpp <span style="color: grey">(b5fa0b5)</span></li>
<li>stage/part/tools/animationtool/KPrPredefinedAnimationsLoader.cpp <span style="color: grey">(909e54f)</span></li>
<li>stage/part/tools/animationtool/KPrShapeAnimationDocker.cpp <span style="color: grey">(21624f8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106559/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>