<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106486/">http://git.reviewboard.kde.org/r/106486/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Very nice! You can merge after fixing the one comment below.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106486/diff/2/?file=85842#file85842line96" style="color: black; font-weight: bold; text-decoration: underline;">filters/words/mobi/PalmDocCompression.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PalmDocCompression::startCompressing(QByteArray input, QDataStream &out)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">96</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">winIndex</span> <span class="o">=</span> <span class="o">-</span><span class="mi">1</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You should fix the indentation here to 4 spaces instead of 8. And also remove the '//}' near the end.</pre>
</div>
<br />
<p>- Inge</p>
<br />
<p>On September 17th, 2012, 10:33 p.m., mojtaba shahi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By mojtaba shahi.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2012, 10:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After calligra Author announced, we had requests to add another filter export to Mobi.
The Amazon kindles use this format for their ebooks.
MOBI is the format used by the MobiPocket Reader. It may have a .mobi extension or it may have a .prc extension. The extension can be changed by the user to either of the accepted forms.
It is a binary file that contains headers include PalmDoc headres and Mobi headers then Text, that is a raw html file, and then images. For Text there are three
modes: no compression, PalmDoc compression and HUFF/CDIC compression, that i implement the palmDoc compression. For html i use OdtHtmlConverter but i need something special for mobi so i handle my changes in class with a flag. Somethings that are special for mobi is handle img tag that for mobi we dont have any href it use another specific attribute named recindex, and for other changes i didn't need meta or ling elements and there is other one for internal links
that i haven't implementedit yet.
you can get more information in http://wiki.mobileread.com/wiki/MOBI#Description
Tools that i use for This export are Calibre for read and compress the file, MobiPacket creator the windows version (there is no linux version :) )
That i tryed to follow the MobiPacket creator files structure.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested some documents and it was good.
It is in its first step don't get hard test from it. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/CMakeLists.txt <span style="color: grey">(941b150)</span></li>
<li>filters/words/epub/OdfParser.cpp <span style="color: grey">(4a6d670)</span></li>
<li>filters/words/epub/OdtHtmlConverter.h <span style="color: grey">(a3e9d33)</span></li>
<li>filters/words/epub/OdtHtmlConverter.cpp <span style="color: grey">(9088546)</span></li>
<li>filters/words/epub/exportepub2.cpp <span style="color: grey">(a2daec8)</span></li>
<li>filters/words/epub/exporthtml.cpp <span style="color: grey">(a919a7a)</span></li>
<li>filters/words/mobi/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/mobi/MobiFile.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/mobi/MobiFile.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/mobi/MobiHeaderGenerator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/mobi/MobiHeaderGenerator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/mobi/PalmDocCompression.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/mobi/PalmDocCompression.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/mobi/exportmobi.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/mobi/exportmobi.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/mobi/words_Mobi_export.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106486/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>