<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106328/">http://git.reviewboard.kde.org/r/106328/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 939afcb3dbee3e7afb08ebbb039a84b3d2b16d00 by Jaroslaw Staniek to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 4th, 2012, 8:05 p.m., Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2012, 8:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Table Designer: adding command to history should only redo() if needed
Fixes commit ee6d9a744aa88af068470: "Ported the tables plugin to KUndo2 to remove dependancy on Qt3Support".
Details:
Table Designer is not written for undo/redo framework that always executes redo() when pushing action on stack, so we needed option to avoid that. Implementation internally adds a means to disable/enable redo().</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested for sample tables; improves editing</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/tables/kexitabledesignerview_p.cpp <span style="color: grey">(d68e77b9d71c126f62eabbf215b916bc1968b4ae)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview_p.h <span style="color: grey">(f74287cffa7d724727f2c6ffb17b24cdc8e9be70)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.cpp <span style="color: grey">(cf6a212c6193e80c1ee08d59ef470b76ccaa5838)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.h <span style="color: grey">(b43505c2bca34c4f6342cac61c072bec8ad60587)</span></li>
<li>kexi/plugins/tables/kexitabledesignercommands.cpp <span style="color: grey">(b626beb036149518781266a2773a2d9b0f270a1a)</span></li>
<li>kexi/plugins/tables/kexitabledesignercommands.h <span style="color: grey">(3a7994c88ac79fcc560b945a2708f935ab43e35f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106328/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>