<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106220/">http://git.reviewboard.kde.org/r/106220/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 8a237521e43cd738cca61d29a1618d6b418a45cd by Yuri Chornoivan to branch calligra/2.5.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 26th, 2012, 2:23 p.m., Yuri Chornoivan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Marijn Kruisselbrink.</div>
<div>By Yuri Chornoivan.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2012, 2:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Plugins page in settings dialog is empty in the current versions of Calligra Sheets (2.5 and git/master).
As there have been a need for some plugin items for a documentation screenshot, it was reasonable to enable some plugins by fixing KSpread leftovers.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The items for function plugins appear in the list. However, it seems that some issues left. Console shows the messages like
plugins should not have a 'lib' prefix: "libkspreadsolver.so"
kdecore (KPluginInfo): found 0 offers for "InformationModule"
Do not know if these are critical.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291343">291343</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sheets/part/ToolRegistry.cpp <span style="color: grey">(bdbac72)</span></li>
<li>sheets/part/dialogs/PreferenceDialog.cpp <span style="color: grey">(4856dad)</span></li>
<li>sheets/plugins/calendar/kspread_plugin_tool_calendar.desktop <span style="color: grey">(4810eec)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106220/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>