<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106283/">http://git.reviewboard.kde.org/r/106283/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Boudewijn Rempt, Inge Wallin, C. Boemann, and Sven Langkamp.</div>
<div>By José Luis Vergara.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Blob tool is the name for a vector brush that creates a broad stroke that fuses with itself and with other shapes that have the same styling, thus helping to create more organic-looking vector images.
This patch implements a very basic version of this tool, missing the ability to fuse shapes with other shapes, which I am postponing until we fix bug 297623 (see thread http://mail.kde.org/pipermail/calligra-devel/2012-August/006633.html ).
Further details and a link to a video in blog http://pentalis.org/kritablog/?p=315
Note: some dependencies (like KarbonCurveFit) need to be moved, I will post a separate review for that, because I need to discuss what directory it belongs to.
I need an easy way to make clear I commit my code in either license, LGPL, GPL, or anything we need for it to fit well in our project; it's not easy to convey since files accumulate more contributors the more time passes by. Suggestions appreciated.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested compilation, loading in applications Karbon and Krita, and basic functioning of the tool. It works (incompletely) as intended for a small group of use cases. Also tested speed, it needs to be faster, but is usable.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/CMakeLists.txt <span style="color: grey">(526499f)</span></li>
<li>plugins/vectortools/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/vectortools/KoBlobTool.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/vectortools/KoBlobTool.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/vectortools/KoBlobToolFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/vectortools/KoBlobToolFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/vectortools/KoVectorToolsPlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/vectortools/KoVectorToolsPlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/vectortools/calligravectortools.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/vectortools/hi22-action-blob-tool.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106283/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>