<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106222/">http://git.reviewboard.kde.org/r/106222/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, and it should also go into 2.5. Thanks!</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On August 26th, 2012, 6:20 p.m., Lukáš Tvrdý wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Cyrille Berger Skott, Boudewijn Rempt, Dmitry Kazakov, and Sven Langkamp.</div>
<div>By Lukáš Tvrdý.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2012, 6:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Deform brush was not usable after regression from the port to NG-iterators.
KisRandomSubAccessor did not provide rawData() (pixels "as they are" in transaction opposed to oldRawData() which refers to pixel status before transaction/change)
KisRandomSubAccessor uses KisRandomAccessorNG now instead of KisRandomConstAccessorNG. KisRandomAccessorNG provides rawData() which are needed in use-cases like deform brush.
My question is (probably for Dmitry) if KisRandomAccessorNG::oldRawData() and KisRandomConstAccessorNG::oldRawData() provides the same data?
Is the semantics the same? What is the purpose of the difference?
Is it ok to backport to 2.5?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested clients of KisRandomSubAccessor:
spray, deform, duplicate, grid and they work as expected
I would like to ask users to test:
wave filter : I tested it, but I'm not sure if the result is correct, it looks ok to me: Filters->Other->Wave
kis_warptransform_worker (Warp mode in transform tool I think)
kis_perspectivetransform_worker (Perspective mode in transform tool I think)
They all depends on correct behaviour of oldRawData so there should be no regressions.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=299701">299701</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/image/kis_random_sub_accessor.h <span style="color: grey">(6950d97)</span></li>
<li>krita/image/kis_random_sub_accessor.cpp <span style="color: grey">(4a978d1)</span></li>
<li>krita/plugins/paintops/deform/deform_brush.cpp <span style="color: grey">(643e5a0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106222/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>