<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106152/">http://git.reviewboard.kde.org/r/106152/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 91f921323fd0735834756b0c67cf70999af522cc by Andreas K. Huettel (dilfridge) to branch master.</pre>
 <br />







<p>- Commit</p>


<br />
<p>On August 23rd, 2012, 9:37 p.m., JarosÅ‚aw Staniek wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.</div>
<div>By JarosÅ‚aw Staniek.</div>


<p style="color: grey;"><i>Updated Aug. 23, 2012, 9:37 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make it possible to disable db drivers even if the libs are present and found

+ renamed drivers/mySQL to drivers/mysql to have single BUILD_mysql config flag (by jstaniek)
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested by building - disabling works</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=305683">305683</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kexi/kexidb/drivers/CMakeLists.txt <span style="color: grey">(917509d)</span></li>

 <li>kexi/kexidb/drivers/mySQL/CMakeLists.txt <span style="color: grey">(86668a2)</span></li>

 <li>kexi/kexidb/drivers/mySQL/kexidb_mysqldriver.desktop <span style="color: grey">(8a50263)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqlconnection.h <span style="color: grey">(b633b9e)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqlconnection.cpp <span style="color: grey">(3ab922e)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqlconnection_p.h <span style="color: grey">(c24c393)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqlconnection_p.cpp <span style="color: grey">(36c8cc1)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqlcursor.h <span style="color: grey">(5284f94)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqlcursor.cpp <span style="color: grey">(fd258cf)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqldriver.h <span style="color: grey">(9eb1813)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqldriver.cpp <span style="color: grey">(06f0641)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqldriver_global.h <span style="color: grey">(1e8b3ff)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqlkeywords.cpp <span style="color: grey">(79fae74)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqlpreparedstatement.h <span style="color: grey">(d174cfd)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqlpreparedstatement.cpp <span style="color: grey">(0dbd812)</span></li>

 <li>kexi/kexidb/drivers/mysql/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/kexidb_mysqldriver.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/mysqlconnection.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/mysqlconnection.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/mysqlconnection_p.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/mysqlconnection_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/mysqlcursor.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/mysqlcursor.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/mysqldriver.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/mysqldriver.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/mysqldriver_global.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/mysqlkeywords.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/mysqlpreparedstatement.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/kexidb/drivers/mysql/mysqlpreparedstatement.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexi/migration/mysql/mysqlmigrate.h <span style="color: grey">(1b10a76)</span></li>

 <li>kexi/migration/mysql/mysqlmigrate.cpp <span style="color: grey">(b3a658f)</span></li>

 <li>kexi/tools/sql_keywords/Makefile <span style="color: grey">(353b5b1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106152/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>