<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106154/">http://git.reviewboard.kde.org/r/106154/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 24th, 2012, 8:14 a.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106154/diff/1/?file=80614#file80614line363" style="color: black; font-weight: bold; text-decoration: underline;">libs/textlayout/KoTextShapeData.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoTextShapeData::loadStyle(const KoXmlElement &element, KoShapeLoadingContext &context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">363</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">delete</span> <span class="n">defaultStyle</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">definitely not
We just sat it as the default style of the paragraphStyle 10 lines above.
Deleting it now would leave a dangling pointer</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sorry i was wrong - as you told me on irc paragraphStyle is deleted too so no need to keep the defaultstyle around</pre>
<br />
<p>- C.</p>
<br />
<p>On August 24th, 2012, 4:35 a.m., Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2012, 4:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When testing I found some memory leaks:
==31293== 1,708 (136 direct, 1,572 indirect) bytes in 1 blocks are definitely lost in loss record 2,039 of 2,111
==31293== at 0x4C2B1C7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==31293== by 0x6B512A1: QObject::QObject(QObject*) (qobject.cpp:721)
==31293== by 0x8767D6D: KoCharacterStyle::KoCharacterStyle(QObject*) (KoCharacterStyle.cpp:343)
==31293== by 0x8773CDF: KoParagraphStyle::KoParagraphStyle(QObject*) (KoParagraphStyle.cpp:97)
==31293== by 0x7F6E40C: KoTextShapeData::loadStyle(KoXmlElement const&, KoShapeLoadingContext&) (KoTextShapeData.cpp:331)
==31293== by 0x8B8EDDD: KoTosContainer::loadText(KoXmlElement const&, KoShapeLoadingContext&) (KoTosContainer.cpp:88)
==31293== by 0x22E762B6: EnhancedPathShape::loadOdf(KoXmlElement const&, KoShapeLoadingContext&) (EnhancedPathShape.cpp:585)
==31293== by 0x8B3C5D0: KoShapeFactoryBase::createShapeFromOdf(KoXmlElement const&, KoShapeLoadingContext&) (KoShapeFactoryBase.cpp:228)
==31293== by 0x8B38735: KoShapeRegistry::Private::createShapeInternal(KoXmlElement const&, KoShapeLoadingContext&, KoXmlElement const&) const (KoShapeRegistry.cpp:313)
==31293== by 0x8B382BB: KoShapeRegistry::createShapeFromOdf(KoXmlElement const&, KoShapeLoadingContext&) const (KoShapeRegistry.cpp:268)
==31293== by 0x1D047D12: KoPAPageBase::loadOdf(KoXmlElement const&, KoShapeLoadingContext&) (KoPAPageBase.cpp:212)
==31293== by 0x1CD5DBEA: KPrPage::loadOdf(KoXmlElement const&, KoShapeLoadingContext&) (KPrPage.cpp:126)
here the default style is not freed as the paragraph styles.
>From the other I don't have the log as it was from a different run. However as we create the d_ptr we should also delete the d_ptr and not d.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/tools/KoInteractionStrategy.cpp <span style="color: grey">(82f286f)</span></li>
<li>libs/textlayout/KoTextShapeData.cpp <span style="color: grey">(7ac7f92)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106154/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>