<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106132/">http://git.reviewboard.kde.org/r/106132/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 23rd, 2012, 6 p.m., <b>Adam Pigg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106132/diff/1/?file=80134#file80134line1248" style="color: black; font-weight: bold; text-decoration: underline;">kexi/core/kexiproject.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static bool checkObjectId(const char* method, int objectID)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1248</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">objectID</span> <span class="o"><=</span> <span class="mi">0</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Im thinking of using this for storage of database wide, global settings, ie, something not associated with a particulat object. perhaps objectid 0 could be a special case for this?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Global settings using this facility is good idea. It will be separate task together with a small GUI for at least minimal set of settings. SO I propose not to extend purpose of this patch.
Regarding meaning of 0: I propose to stay with relationships, so global area will have just another ID (just like any other plugin type), assigned dynamically. This way we would get backward compatibility and consistency (relationships for every record of the kexi__userdata table).
So I am dropping this issue in this very review if you do not mind.</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On August 23rd, 2012, 12:08 a.m., Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2012, 12:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add support for user data storage and remember column widths in table
Core
*Add support for user data storage
BUG:305074
Table View
*Remember column widths in tabular data view
BUG:230994
KexiDB
*Added helpers needed for saving string lists and removing data</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on data table view</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=230994">230994</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=305074">305074</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/core/KexiView.h <span style="color: grey">(283236c)</span></li>
<li>kexi/core/KexiView.cpp <span style="color: grey">(06763d9)</span></li>
<li>kexi/core/KexiWindow.h <span style="color: grey">(ce67eff)</span></li>
<li>kexi/core/KexiWindow.cpp <span style="color: grey">(16c1daf)</span></li>
<li>kexi/core/kexiproject.h <span style="color: grey">(855291a)</span></li>
<li>kexi/core/kexiproject.cpp <span style="color: grey">(189bbf2)</span></li>
<li>kexi/main/KexiMainWindow_p.h <span style="color: grey">(9c24236)</span></li>
<li>kexi/plugins/scripting/kexidb/kexidbfield.h <span style="color: grey">(ce5fc5b)</span></li>
<li>kexi/plugins/scripting/kexidb/kexidbfield.cpp <span style="color: grey">(9829bac)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.cpp <span style="color: grey">(245eaa1)</span></li>
<li>kexi/widget/dataviewcommon/KexiTableViewColumn.h <span style="color: grey">(cc8326e)</span></li>
<li>kexi/widget/dataviewcommon/KexiTableViewColumn.cpp <span style="color: grey">(90ea429)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp <span style="color: grey">(22345a5)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.cpp <span style="color: grey">(1128bd4)</span></li>
<li>kexi/widget/dataviewcommon/kexitableviewdata.h <span style="color: grey">(b3f9aac)</span></li>
<li>kexi/widget/tableview/kexidatatable.h <span style="color: grey">(6cb8854)</span></li>
<li>kexi/widget/tableview/kexidatatable.cpp <span style="color: grey">(ad60d6b)</span></li>
<li>kexi/widget/tableview/kexidatatableview.h <span style="color: grey">(0ddcc1e)</span></li>
<li>kexi/widget/tableview/kexidatatableview.cpp <span style="color: grey">(775c33d)</span></li>
<li>libs/db/field.h <span style="color: grey">(7ae2653)</span></li>
<li>libs/db/field.cpp <span style="color: grey">(0dff112)</span></li>
<li>libs/db/utils.h <span style="color: grey">(007c043)</span></li>
<li>libs/db/utils.cpp <span style="color: grey">(05af25a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106132/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>