<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106093/">http://git.reviewboard.kde.org/r/106093/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 20th, 2012, 5:55 p.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106093/diff/2/?file=79089#file79089line31" style="color: black; font-weight: bold; text-decoration: underline;">stage/part/KPrShapeApplicationData.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qDeleteAll</span><span class="p">(</span> <span class="n">m_animations</span> <span class="p">);</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This seems to be a memory leak.</pre>
</blockquote>
<p>On August 21st, 2012, 12:51 a.m., <b>Paul Mendez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Animations are deleted in KPrAnimationCreateCommand and KPrAnimationRemoveCommand</pre>
</blockquote>
<p>On August 21st, 2012, 4:12 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this needs to come back. The KPrAnimationCreateCommand and the KPrAnimationRemoveCommand only delete the animations when the animation is removed or when adding is undone. However all animations that are loaded from the file or not removed until the end of the document also need to be deleted.</pre>
</blockquote>
<p>On August 21st, 2012, 1:34 p.m., <b>Paul Mendez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Other animations are children of substeps and are deleted when the steps, substeps structure is deleted.</pre>
</blockquote>
<p>On August 22nd, 2012, 4:02 p.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But what happens if the user deletes a shape. Then the animations of that shape are never freed or do I miss something?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you are rigth. I am going to add deletion of animations when shape is removed</pre>
<br />
<p>- Paul</p>
<br />
<p>On August 21st, 2012, 3:17 p.m., Paul Mendez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Paul Mendez.</div>
<p style="color: grey;"><i>Updated Aug. 21, 2012, 3:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">GSoC work on Animation Tool Docker:
- List to display current animations, change order, duration and type of animation
- Time line view for advanced edition of start time and duration
- Live preview of animations
- Widget to add new animations
- Automatic preview of animations (Can be disabled and Stage remembers your preference)
- Alternative animation preview using hover buttons.
- Automatic drawing of motion path icons using shape stored on xml description
- Automatic loading of predefined animations from a xml file (I have added some predefined animations).
- Basic edition of motion path animations (Some predefined motion path animations have been added on the xml file).
- Refactor of KPrAnimateMotion class (class that loads and saves motion paths)
- Data model to store and edit animations of a document.
- Unit test for the animations data model.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/tools/KoPathTool.h <span style="color: grey">(a4bcb5047cce5f817fb68d3ab35da38cca93cc54)</span></li>
<li>libs/flake/tools/KoPathTool.cpp <span style="color: grey">(8ad20a6eee4f02a00bd9d15509a777e4c3c8b000)</span></li>
<li>libs/widgets/KoViewItemContextBar.h <span style="color: grey">(c8a7017ccabdcb09fd3a7edfdb6697a932e0974e)</span></li>
<li>libs/widgets/KoViewItemContextBar.cpp <span style="color: grey">(163155eeee605f690ed5c754bb04f78d53edb696)</span></li>
<li>stage/part/CMakeLists.txt <span style="color: grey">(77497a71bf60a703f996442e5a8795a62986f582)</span></li>
<li>stage/part/KPrDocument.h <span style="color: grey">(a9c7c3b2414172218b268fb95c96d39dd1f1ec9e)</span></li>
<li>stage/part/KPrDocument.cpp <span style="color: grey">(de18a8f080c76aeebeaad557c00b3f1d9ab062ed)</span></li>
<li>stage/part/KPrEndOfSlideShowPage.cpp <span style="color: grey">(78907aa1a379f336f3c68ea0690d0c8741219bfd)</span></li>
<li>stage/part/KPrMasterPage.h <span style="color: grey">(29190e33d910f1c2dd339d39c585cbfba6fb9b5c)</span></li>
<li>stage/part/KPrMasterPage.cpp <span style="color: grey">(d75b6af8a17dcf2e594c6f3597ab805a63fe77cf)</span></li>
<li>stage/part/KPrPage.cpp <span style="color: grey">(ad4af851ae2a1eb8d7681a80f4336c9e43856a0b)</span></li>
<li>stage/part/KPrPageData.h <span style="color: grey">(88ee96680c165da54f8d7c270a1dc4961ffdd5a7)</span></li>
<li>stage/part/KPrPageData.cpp <span style="color: grey">(970fb6e7e791bbffc4e49561e276ce5e86185b32)</span></li>
<li>stage/part/KPrShapeAnimations.h <span style="color: grey">(7558efa420be30ebf975945fcbdec3a1c72d1311)</span></li>
<li>stage/part/KPrShapeAnimations.cpp <span style="color: grey">(b479ed79560e51e69d06adfe3b02ed50f600928e)</span></li>
<li>stage/part/KPrShapeApplicationData.h <span style="color: grey">(ae8d685a61625625d8d2ff61b2986c05b918e855)</span></li>
<li>stage/part/KPrShapeApplicationData.cpp <span style="color: grey">(691446d01381d4eff701d84ce4bf9dc12149cdce)</span></li>
<li>stage/part/KPrViewModePreviewShapeAnimations.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrViewModePreviewShapeAnimations.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/animations/KPrAnimateMotion.h <span style="color: grey">(29cdd3f0453e0e0d7e50025699f354357967d2c5)</span></li>
<li>stage/part/animations/KPrAnimateMotion.cpp <span style="color: grey">(575cef1daa769e770b9f678f4cf9c7b424153f8a)</span></li>
<li>stage/part/animations/KPrAnimationBase.h <span style="color: grey">(066974efdf11d0f13f37d0b4854d49bfb2079e5d)</span></li>
<li>stage/part/animations/KPrAnimationBase.cpp <span style="color: grey">(57861e1c4af4fb9218b45f88a6c9dda0f5f0af80)</span></li>
<li>stage/part/animations/KPrAnimationFactory.h <span style="color: grey">(b0e7a8db480e713a75427460c3bc1521d06f37a3)</span></li>
<li>stage/part/animations/KPrAnimationLoader.cpp <span style="color: grey">(24cc17b01ac2c7a45edbb78c6adfaa31fac47abd)</span></li>
<li>stage/part/animations/KPrAnimationStep.h <span style="color: grey">(26a9fcec4b1d894ffe4d7d1dd2458a34c35e3d64)</span></li>
<li>stage/part/animations/KPrAnimationSubStep.h <span style="color: grey">(83cab65ab078675c380ccbf4b60dab99e83619f1)</span></li>
<li>stage/part/animations/KPrShapeAnimation.h <span style="color: grey">(f5d9ac3b796e75f16970f80245e1fbb6673fe1b9)</span></li>
<li>stage/part/animations/KPrShapeAnimation.cpp <span style="color: grey">(988cd14098d8ac1f9290b858540215d75d97f9f3)</span></li>
<li>stage/part/animations/animations.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/commands/KPrAnimationCreateCommand.h <span style="color: grey">(831317e9a386e7da4100d27dfbf5aab5b382b28d)</span></li>
<li>stage/part/commands/KPrAnimationCreateCommand.cpp <span style="color: grey">(3c06155bbb6afd6668bef6998bd1fd4c20534b8b)</span></li>
<li>stage/part/commands/KPrAnimationEditNodeTypeCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/commands/KPrAnimationEditNodeTypeCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/commands/KPrAnimationRemoveCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/commands/KPrAnimationRemoveCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/commands/KPrEditAnimationTimeLineCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/commands/KPrEditAnimationTimeLineCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/commands/KPrReorderAnimationCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/commands/KPrReorderAnimationCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/commands/KPrReplaceAnimationCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/commands/KPrReplaceAnimationCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tests/CMakeLists.txt <span style="color: grey">(bac9354b91bafcd38303267ad5759749b38b9c2c)</span></li>
<li>stage/part/tests/MockShapeAnimation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tests/PAMock.h <span style="color: grey">(d05c38920e074092d4ab47f8f5dc66b7dda51a5b)</span></li>
<li>stage/part/tests/TestShapeAnimations.h <span style="color: grey">(045bc2e9f20d9fce69cc1deb2f8fd462e47f64ea)</span></li>
<li>stage/part/tests/TestShapeAnimations.cpp <span style="color: grey">(b077a550417f3b4f3dd17105b29d455992d67c56)</span></li>
<li>stage/part/tests/modeltest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tests/modeltest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/CMakeLists.txt <span style="color: grey">(5f5cb93f681ab95b0294de540e681d44ea9d27cb)</span></li>
<li>stage/part/tools/animationtool/KPrAnimationGroupProxyModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrAnimationGroupProxyModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrAnimationSelectorWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrAnimationSelectorWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrAnimationTool.h <span style="color: grey">(dbf12b9226f4da7b975d49ee19e5c7568cef7367)</span></li>
<li>stage/part/tools/animationtool/KPrAnimationTool.cpp <span style="color: grey">(99f3d5428f9a761d5376af6a5c1cf9a512266347)</span></li>
<li>stage/part/tools/animationtool/KPrAnimationsTimeLineView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrAnimationsTimeLineView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrCollectionItemModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrCollectionItemModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrEditAnimationsWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrEditAnimationsWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrPredefinedAnimationsLoader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrPredefinedAnimationsLoader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrShapeAnimationDocker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrShapeAnimationDocker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrTimeLineHeader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrTimeLineHeader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrTimeLineView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/tools/animationtool/KPrTimeLineView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/CMakeLists.txt <span style="color: grey">(dda7ac06d627e7e84f754d000fd54fc9952a3780)</span></li>
<li>stage/pics/animations/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi32-action-after_previous.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi32-action-edit_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi32-action-onclick.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi32-action-unrecognized_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi32-action-with_previous.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-appear_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-bounce_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-collapse_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-crawl_out_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-custom_animations.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-disappear_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-emphasis_animations.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-entrance_animations.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-exit_animations.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-falling_in_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-flash_once_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-fly_in_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-fly_in_slow_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-fly_out_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-horizontal_animations.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-in_animations.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-motion_path_animations.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-movie_credits_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-out_animations.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-spiral_in_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-spiral_out_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-stretchy_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-swish_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-swivel_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-thread_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-vertical_animations.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/pics/animations/hi64-action-zoom_animation.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106093/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>