<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106064/">http://git.reviewboard.kde.org/r/106064/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2012, 1:08 p.m., <b>Arjen Hiemstra</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Two things glare at me from this patch:
- Why put it into Words' directory instead of its own top level? The goal for this is - as I understand it - to become a separate application, so why not start off the right way? If it is a problem with Words' libraries, is it not better to fix that first than to have to risk major breakage later on?
- The prefix CAu is a really awkward prefix imo. Personally I prefer namespaces, using those you would simply declare "namespace Calligra::Author" and be done with it. But if you're sticking with prefixes, why not use CAuth? It seems to me a far more natural prefix considering CA is already taken.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Because we want to minimize code duplication. It's difficult to know at first what we really need to have on our own and what we could share. We will use the time for the development the 2.6 series to find that out, refactor common parts into libraries and plugins and truly become our own application. This is hinted at in the original admission.
2. We couldn't find anything really good, and yes, CA is already taken by Calligra Active. I think CAuth is worse because it leads the brain to think about authentication. And we wanted it to be short. CAu is not ideal but it's the best we could come up with.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2012, 1:08 p.m., <b>Arjen Hiemstra</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106064/diff/3/?file=78616#file78616line1" style="color: black; font-weight: bold; text-decoration: underline;">words/part/author/author_readonly.rc</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><!DOCTYPE kpartgui SYSTEM "kpartgui.dtd" ><kpartgui name="Author" version="4"></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does it need a read only UI? To me that does not make much sense. Also, version again.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think conqueror uses the readonly Ui by default. </pre>
<br />
<p>- Inge</p>
<br />
<p>On August 19th, 2012, 6:20 a.m., Gopalakrishna Bhat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Gopalakrishna Bhat.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2012, 6:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the first step in realizing [1]. Currently author resides in words/part and will eventually moved out to a directory of its own. This patch is currently a work in progress and to evaluate that we are on the right path.
Currently there is a known issue that various options of the text tool are not shown for the first time when the application is launched(see attached snapshot). Once I explicitly activate the tool by switching to a different tool and back it works fine. Any ideas what can be wrong?
[1] http://www.calligra.org/news/calligra-announces-author/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>words/part/CMakeLists.txt <span style="color: grey">(cdeca2b)</span></li>
<li>words/part/KWPart.h <span style="color: grey">(5b6621b)</span></li>
<li>words/part/KWPart.cpp <span style="color: grey">(f94354a)</span></li>
<li>words/part/author/CAuAboutData.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuFactoryInit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuPart.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuPart.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/author.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/author.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/author_readonly.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/authorpart.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/authorrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106064/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106064/s/678/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/17/text_tool_400x100.png" style="border: 1px black solid;" alt="Text Tool" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>