<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106064/">http://git.reviewboard.kde.org/r/106064/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 18th, 2012, 8:24 a.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106064/diff/2/?file=78322#file78322line29" style="color: black; font-weight: bold; text-decoration: underline;">words/part/author/main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">extern "C" KDE_EXPORT int kdemain(int argc, char **argv)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#ifdef Q_WS_X11</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why to hardcode it here? No other app, despote potential gains, do that in Calligra. You may want to put an advice (to use command line switch for calligraauthor) on the community.kde.org for Author if there's specific need like this.
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Calligra Words uses it currently. There was a discussion on the mailing list about this http://www.mail-archive.com/calligra-devel@kde.org/msg00234.html</pre>
<br />
<p>- Gopalakrishna</p>
<br />
<p>On August 17th, 2012, 8:46 p.m., Gopalakrishna Bhat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Gopalakrishna Bhat.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2012, 8:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the first step in realizing [1]. Currently author resides in words/part and will eventually moved out to a directory of its own. This patch is currently a work in progress and to evaluate that we are on the right path.
Currently there is a known issue that various options of the text tool are not shown for the first time when the application is launched(see attached snapshot). Once I explicitly activate the tool by switching to a different tool and back it works fine. Any ideas what can be wrong?
[1] http://www.calligra.org/news/calligra-announces-author/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>words/part/CMakeLists.txt <span style="color: grey">(cdeca2b)</span></li>
<li>words/part/KWPart.h <span style="color: grey">(5b6621b)</span></li>
<li>words/part/KWPart.cpp <span style="color: grey">(f94354a)</span></li>
<li>words/part/author/CAuAboutData.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuFactoryInit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuPart.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuPart.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/author.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/author.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/author_readonly.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/authorpart.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/authorrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106064/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106064/s/678/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/17/text_tool_400x100.png" style="border: 1px black solid;" alt="Text Tool" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>