<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106064/">http://git.reviewboard.kde.org/r/106064/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2012, 1:50 p.m., <b>José Luis Vergara</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just turned this patch into a branch called
author-testpatch-pentalis
So others can test. I will review in a moment, after I finish testing.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested:
The branch compiled correctly -- check
calligraauthor and calligrawords stored their settings separately -- check
Bugs I found in Author were present in Words too (with the exception of the known issue mentioned in the review request), so those are not new bugs -- check
I checked the 3 files modified for Words, and if they had introduced a new bug I should've noticed it the moment I run both applications in parallel, something involving the document view, I saw nothing wrong, so I think this branch doesn't introduce any new issue.
I say Ship It, remember to squash it so the whole creation of Author is seen as a single commit.</pre>
<br />
<p>- José Luis</p>
<br />
<p>On August 19th, 2012, 6:20 a.m., Gopalakrishna Bhat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Gopalakrishna Bhat.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2012, 6:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the first step in realizing [1]. Currently author resides in words/part and will eventually moved out to a directory of its own. This patch is currently a work in progress and to evaluate that we are on the right path.
Currently there is a known issue that various options of the text tool are not shown for the first time when the application is launched(see attached snapshot). Once I explicitly activate the tool by switching to a different tool and back it works fine. Any ideas what can be wrong?
[1] http://www.calligra.org/news/calligra-announces-author/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>words/part/CMakeLists.txt <span style="color: grey">(cdeca2b)</span></li>
<li>words/part/KWPart.h <span style="color: grey">(5b6621b)</span></li>
<li>words/part/KWPart.cpp <span style="color: grey">(f94354a)</span></li>
<li>words/part/author/CAuAboutData.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuFactoryInit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuPart.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuPart.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/author.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/author.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/author_readonly.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/authorpart.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/authorrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106064/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106064/s/678/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/17/text_tool_400x100.png" style="border: 1px black solid;" alt="Text Tool" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>