<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106078/">http://git.reviewboard.kde.org/r/106078/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 5a58202b950c62565e30a6b321232c1268f5b6c5 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 18th, 2012, 3:46 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2012, 3:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KDialog::marginHint() and KDialog::spacingHint() are left-overs from KDE3 times, no more need to explicitely set the margins/spacing using these methods.
Did not mess around with Kexi code, as I do not have a complete picture of its custom layouting and it might rely on the values as returned from both methods.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/libdialogfilter/exportsizedia.cpp <span style="color: grey">(6fe5fde)</span></li>
<li>krita/ui/dialogs/kis_dlg_preferences.cc <span style="color: grey">(1bf890d)</span></li>
<li>libs/main/KoExistingDocumentPane.cpp <span style="color: grey">(85e6d5f)</span></li>
<li>libs/main/KoVersionDialog.cpp <span style="color: grey">(361886d)</span></li>
<li>libs/main/config/KoConfigDocumentPage.cpp <span style="color: grey">(7755a2a)</span></li>
<li>libs/main/config/KoConfigGridPage.cpp <span style="color: grey">(356d5e8)</span></li>
<li>libs/main/config/KoConfigMiscPage.cpp <span style="color: grey">(dfb922e)</span></li>
<li>libs/widgets/KoColorSetWidget.cpp <span style="color: grey">(c50ab77)</span></li>
<li>plugins/textediting/thesaurus/Thesaurus.cpp <span style="color: grey">(5bf6269)</span></li>
<li>sheets/dialogs/AngleDialog.cpp <span style="color: grey">(ea33eda)</span></li>
<li>sheets/dialogs/AutoFormatDialog.cpp <span style="color: grey">(4f4c2f0)</span></li>
<li>sheets/dialogs/CharacterSelectDialog.cpp <span style="color: grey">(ce5e62b)</span></li>
<li>sheets/dialogs/CommentDialog.cpp <span style="color: grey">(c511cb4)</span></li>
<li>sheets/dialogs/FormulaDialog.cpp <span style="color: grey">(783ab1a)</span></li>
<li>sheets/dialogs/GotoDialog.cpp <span style="color: grey">(b948199)</span></li>
<li>sheets/dialogs/InsertDialog.cpp <span style="color: grey">(16e5e4c)</span></li>
<li>sheets/dialogs/LayoutDialog.cpp <span style="color: grey">(673614f)</span></li>
<li>sheets/dialogs/ListDialog.cpp <span style="color: grey">(477e015)</span></li>
<li>sheets/dialogs/NamedAreaDialog.cpp <span style="color: grey">(9d38cb2)</span></li>
<li>sheets/dialogs/PasteInsertDialog.cpp <span style="color: grey">(5f28a8f)</span></li>
<li>sheets/dialogs/SeriesDialog.cpp <span style="color: grey">(1e711fb)</span></li>
<li>sheets/dialogs/ShowColRowDialog.cpp <span style="color: grey">(3eb8265)</span></li>
<li>sheets/dialogs/ShowDialog.cpp <span style="color: grey">(b223963)</span></li>
<li>sheets/dialogs/ValidityDialog.cpp <span style="color: grey">(fd643aa)</span></li>
<li>sheets/tests/inspector.cpp <span style="color: grey">(c20cfca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106078/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>