<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105975/">http://git.reviewboard.kde.org/r/105975/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like the idea of painting it in the bg shape. I see no reason why it should be only a temporary solution.
The size without margin, scares me (mostly with respect to mso files - i know writer is way too simple, and i read your mail to the odf tc :) )
We need to run a full cs tester session on this.
the redundant setting of background you remove. I'm not sure it's not needed, though i can't say where it wouldf be. Scares me though.</pre>
<br />
<p>- C.</p>
<br />
<p>On August 10th, 2012, 11:52 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and C. Boemann.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2012, 11:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I had the idea to render the column separators using the background shapes. What do you think? Would that be alright at least as a temporary solution?
Patch also fixes page background ignoring the margins. At least LO/AOO does not paint the background in the margin. Sadly the attribute "draw:background-size" is not available for <style:page-layout-properties>, only for <style:drawing-page-properties>. Filed a complain on the office-comment mailinglist.
And patch removes redundant setting of background to frame shapes in KWTextFrameSet::setPageStyle(...).
Okay to backport to 2.5?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>words/part/frames/KWFrameLayout.cpp <span style="color: grey">(d9675b0)</span></li>
<li>words/part/frames/KWTextFrameSet.cpp <span style="color: grey">(7afa7bf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105975/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>