<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105266/">http://git.reviewboard.kde.org/r/105266/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 7e3258d4968dfcc686b21315bbfd221c1f9fca56 by Boudewijn Rempt to branch master.</pre>
 <br />







<p>- Commit</p>


<br />
<p>On July 19th, 2012, 2:28 p.m., Boudewijn Rempt wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Boudewijn Rempt.</div>


<p style="color: grey;"><i>Updated July 19, 2012, 2:28 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Create a new docker with basically all the options of the Mari color management toolbar. It works both in CPU and in GPU mode, with the CPU mode being very slow, of course.

This adds a new optional dependency, OpenColorIO (which depends on OpenImageIO).</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/modules/FindOCIO.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>cmake/modules/FindOIIO.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/CMakeLists.txt <span style="color: grey">(5aede20)</span></li>

 <li>krita/config-ocio.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/config-oiio.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/data/shaders/CMakeLists.txt <span style="color: grey">(03ac39a)</span></li>

 <li>krita/data/shaders/hdr_exposure.frag <span style="color: grey">(0917256)</span></li>

 <li>krita/image/kis_colorspace_convert_visitor.h <span style="color: grey">(34b0ee5)</span></li>

 <li>krita/image/kis_colorspace_convert_visitor.cpp <span style="color: grey">(70316a7)</span></li>

 <li>krita/image/kis_fixed_paint_device.h <span style="color: grey">(33fbbc1)</span></li>

 <li>krita/image/kis_fixed_paint_device.cpp <span style="color: grey">(1f2933f)</span></li>

 <li>krita/image/kis_group_layer.cc <span style="color: grey">(dd3773a)</span></li>

 <li>krita/image/kis_image.h <span style="color: grey">(77b1669)</span></li>

 <li>krita/image/kis_image.cc <span style="color: grey">(398b7f0)</span></li>

 <li>krita/image/kis_layer.cc <span style="color: grey">(5f8d39c)</span></li>

 <li>krita/image/kis_mask.cc <span style="color: grey">(4d56fec)</span></li>

 <li>krita/image/kis_paint_device.h <span style="color: grey">(f1725d3)</span></li>

 <li>krita/image/kis_paint_device.cc <span style="color: grey">(607b687)</span></li>

 <li>krita/image/kis_painter.h <span style="color: grey">(8ea7949)</span></li>

 <li>krita/image/kis_painter.cc <span style="color: grey">(4ad9a37)</span></li>

 <li>krita/image/kis_pixel_selection.h <span style="color: grey">(121beb6)</span></li>

 <li>krita/image/kis_pixel_selection.cpp <span style="color: grey">(47edef1)</span></li>

 <li>krita/image/kis_selection_based_layer.cpp <span style="color: grey">(de39d43)</span></li>

 <li>krita/image/tests/kis_colorspace_convert_visitor_test.cpp <span style="color: grey">(db2aa14)</span></li>

 <li>krita/image/tests/kis_fixed_paint_device_test.cpp <span style="color: grey">(ea4b456)</span></li>

 <li>krita/image/tests/kis_image_test.cpp <span style="color: grey">(d9f2b95)</span></li>

 <li>krita/plugins/colorspaces/ctlcs/KoCtlColorConversionTransformation.h <span style="color: grey">(93101c0)</span></li>

 <li>krita/plugins/colorspaces/ctlcs/KoCtlColorConversionTransformation.cpp <span style="color: grey">(318043e)</span></li>

 <li>krita/plugins/colorspaces/ctlcs/KoCtlColorProfile.h <span style="color: grey">(7fabffe)</span></li>

 <li>krita/plugins/colorspaces/ctlcs/KoCtlColorProfile.cpp <span style="color: grey">(66897c2)</span></li>

 <li>krita/plugins/colorspaces/ctlcs/KoCtlColorSpace.cpp <span style="color: grey">(6ba3707)</span></li>

 <li>krita/plugins/extensions/colorspaceconversion/colorspaceconversion.cc <span style="color: grey">(3bb48a8)</span></li>

 <li>krita/plugins/extensions/colorspaceconversion/dlg_colorspaceconversion.cc <span style="color: grey">(9c72e54)</span></li>

 <li>krita/plugins/extensions/colorspaceconversion/wdgconvertcolorspace.ui <span style="color: grey">(8701468)</span></li>

 <li>krita/plugins/extensions/dockers/CMakeLists.txt <span style="color: grey">(6f784dc)</span></li>

 <li>krita/plugins/extensions/dockers/advancedcolorselector/kis_common_colors.cpp <span style="color: grey">(c6467e4)</span></li>

 <li>krita/plugins/extensions/dockers/defaultdockers/CMakeLists.txt <span style="color: grey">(c11a39f)</span></li>

 <li>krita/plugins/extensions/dockers/defaultdockers/defaultdockers.cpp <span style="color: grey">(7a0cbdb)</span></li>

 <li>krita/plugins/extensions/dockers/defaultdockers/kis_birdeye_box.h <span style="color: grey">(142b2ab)</span></li>

 <li>krita/plugins/extensions/dockers/defaultdockers/kis_birdeye_box.cc <span style="color: grey">(c6f5492)</span></li>

 <li>krita/plugins/extensions/dockers/defaultdockers/wdgbirdeye.ui <span style="color: grey">(e10037a)</span></li>

 <li>krita/plugins/extensions/dockers/historydocker/KisUndoModel.cpp <span style="color: grey">(256fb77)</span></li>

 <li>krita/plugins/extensions/dockers/lut/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/extensions/dockers/lut/krita_lutdocker.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/extensions/dockers/lut/lutdocker.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/extensions/dockers/lut/lutdocker.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/extensions/dockers/lut/lutdocker_dock.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/extensions/dockers/lut/lutdocker_dock.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/extensions/dockers/lut/ocio_display_filter.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/extensions/dockers/lut/ocio_display_filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/extensions/dockers/lut/wdglut.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp <span style="color: grey">(4b79bcb)</span></li>

 <li>krita/plugins/filters/fastcolortransfer/kis_wdg_fastcolortransfer.cpp <span style="color: grey">(6fd7d8c)</span></li>

 <li>krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_filter.cpp <span style="color: grey">(0e60b93)</span></li>

 <li>krita/plugins/formats/CMakeLists.txt <span style="color: grey">(ea786da)</span></li>

 <li>krita/plugins/formats/bmp/CMakeLists.txt <span style="color: grey">(93d7595)</span></li>

 <li>krita/plugins/formats/bmp/kis_bmp_export.cpp <span style="color: grey">(5df7eac)</span></li>

 <li>krita/plugins/formats/jpeg/kis_jpeg_converter.cc <span style="color: grey">(58afd38)</span></li>

 <li>krita/plugins/formats/oiio/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/formats/oiio/kis_oiio_export.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/formats/oiio/kis_oiio_export.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/formats/oiio/kis_oiio_import.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/formats/oiio/kis_oiio_import.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/formats/oiio/krita_oiio.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/formats/oiio/krita_oiio_export.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/formats/oiio/krita_oiio_import.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/plugins/formats/ppm/kis_ppm_export.cpp <span style="color: grey">(7b146f1)</span></li>

 <li>krita/plugins/formats/tiff/kis_tiff_converter.cc <span style="color: grey">(ee99530)</span></li>

 <li>krita/plugins/paintops/colorsmudge/kis_colorsmudgeop.cpp <span style="color: grey">(15594d4)</span></li>

 <li>krita/plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.cpp <span style="color: grey">(92fcec1)</span></li>

 <li>krita/plugins/paintops/hatching/kis_hatching_paintop.cpp <span style="color: grey">(c104753)</span></li>

 <li>krita/plugins/paintops/libbrush/kis_auto_brush.cpp <span style="color: grey">(8472314)</span></li>

 <li>krita/plugins/paintops/libbrush/kis_brush.cpp <span style="color: grey">(049f431)</span></li>

 <li>krita/plugins/paintops/libbrush/kis_gbr_brush.cpp <span style="color: grey">(d164d18)</span></li>

 <li>krita/plugins/paintops/libbrush/tests/kis_auto_brush_test.cpp <span style="color: grey">(6bf6b79)</span></li>

 <li>krita/plugins/paintops/libbrush/tests/kis_brush_test.cpp <span style="color: grey">(f02ac0b)</span></li>

 <li>krita/plugins/paintops/mypaint/mypaint_surface.cpp <span style="color: grey">(1d84886)</span></li>

 <li>krita/plugins/tools/tool_transform2/kis_tool_transform.cc <span style="color: grey">(fa41229)</span></li>

 <li>krita/sdk/tests/filestest.h <span style="color: grey">(acba4da)</span></li>

 <li>krita/ui/CMakeLists.txt <span style="color: grey">(b002541)</span></li>

 <li>krita/ui/canvas/kis_canvas2.h <span style="color: grey">(aa410c4)</span></li>

 <li>krita/ui/canvas/kis_canvas2.cpp <span style="color: grey">(6396b29)</span></li>

 <li>krita/ui/canvas/kis_display_filter.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/ui/canvas/kis_display_filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>krita/ui/canvas/kis_image_pyramid.h <span style="color: grey">(1dcef79)</span></li>

 <li>krita/ui/canvas/kis_image_pyramid.cpp <span style="color: grey">(33ac3ab)</span></li>

 <li>krita/ui/canvas/kis_prescaled_projection.h <span style="color: grey">(9e2caab)</span></li>

 <li>krita/ui/canvas/kis_prescaled_projection.cpp <span style="color: grey">(8c2f043)</span></li>

 <li>krita/ui/canvas/kis_projection_backend.h <span style="color: grey">(b9aa38c)</span></li>

 <li>krita/ui/dialogs/kis_dlg_preferences.h <span style="color: grey">(6193e7b)</span></li>

 <li>krita/ui/dialogs/kis_dlg_preferences.cc <span style="color: grey">(3efcd21)</span></li>

 <li>krita/ui/forms/wdgcolorsettings.ui <span style="color: grey">(b7e3395)</span></li>

 <li>krita/ui/kis_bookmarked_filter_configurations_model.cc <span style="color: grey">(777627b)</span></li>

 <li>krita/ui/kis_canvas_resource_provider.h <span style="color: grey">(6bd5506)</span></li>

 <li>krita/ui/kis_canvas_resource_provider.cpp <span style="color: grey">(8e104c6)</span></li>

 <li>krita/ui/kis_clipboard.cc <span style="color: grey">(744c767)</span></li>

 <li>krita/ui/kis_config.h <span style="color: grey">(8e717d5)</span></li>

 <li>krita/ui/kis_config.cc <span style="color: grey">(238f06f)</span></li>

 <li>krita/ui/kis_custom_pattern.cc <span style="color: grey">(722d43d)</span></li>

 <li>krita/ui/kis_exposure_visitor.h <span style="color: grey">(8e53f58)</span></li>

 <li>krita/ui/kis_exposure_visitor.cc <span style="color: grey">(8a64776)</span></li>

 <li>krita/ui/kis_filters_model.cc <span style="color: grey">(e1b6b76)</span></li>

 <li>krita/ui/kis_mimedata.cpp <span style="color: grey">(63db3cc)</span></li>

 <li>krita/ui/kis_png_converter.cpp <span style="color: grey">(232cb5e)</span></li>

 <li>krita/ui/kis_view2.cpp <span style="color: grey">(438bc3a)</span></li>

 <li>krita/ui/opengl/kis_opengl_canvas2.cpp <span style="color: grey">(b874c29)</span></li>

 <li>krita/ui/opengl/kis_opengl_hdr_exposure_program.h <span style="color: grey">(60b3fc4)</span></li>

 <li>krita/ui/opengl/kis_opengl_hdr_exposure_program.cpp <span style="color: grey">(3b415e2)</span></li>

 <li>krita/ui/opengl/kis_opengl_image_textures.h <span style="color: grey">(ebe0759)</span></li>

 <li>krita/ui/opengl/kis_opengl_image_textures.cpp <span style="color: grey">(d4f282d)</span></li>

 <li>krita/ui/opengl/kis_texture_tile_update_info.h <span style="color: grey">(f100ec6)</span></li>

 <li>krita/ui/widgets/kis_scratch_pad.cpp <span style="color: grey">(ca368eb)</span></li>

 <li>libs/flake/KoOdfWorkaround.cpp <span style="color: grey">(d6aff39)</span></li>

 <li>libs/pigment/KoBasicHistogramProducers.cpp <span style="color: grey">(14cee0b)</span></li>

 <li>libs/pigment/KoColor.cpp <span style="color: grey">(5a70272)</span></li>

 <li>libs/pigment/KoColorConversionAlphaTransformation.h <span style="color: grey">(2b17e68)</span></li>

 <li>libs/pigment/KoColorConversionAlphaTransformation.cpp <span style="color: grey">(63f92c3)</span></li>

 <li>libs/pigment/KoColorConversionCache.h <span style="color: grey">(d2ecf64)</span></li>

 <li>libs/pigment/KoColorConversionCache.cpp <span style="color: grey">(6a2d68c)</span></li>

 <li>libs/pigment/KoColorConversionSystem.h <span style="color: grey">(8378d96)</span></li>

 <li>libs/pigment/KoColorConversionSystem.cpp <span style="color: grey">(aeb0975)</span></li>

 <li>libs/pigment/KoColorConversionTransformation.h <span style="color: grey">(8d461d9)</span></li>

 <li>libs/pigment/KoColorConversionTransformation.cpp <span style="color: grey">(0ab863f)</span></li>

 <li>libs/pigment/KoColorConversionTransformationAbstractFactory.h <span style="color: grey">(bddb253)</span></li>

 <li>libs/pigment/KoColorProfile.h <span style="color: grey">(6835686)</span></li>

 <li>libs/pigment/KoColorProfile.cpp <span style="color: grey">(5ca60a0)</span></li>

 <li>libs/pigment/KoColorSpace.h <span style="color: grey">(b61a211)</span></li>

 <li>libs/pigment/KoColorSpace.cpp <span style="color: grey">(c20a9a3)</span></li>

 <li>libs/pigment/KoColorSpaceAbstract.h <span style="color: grey">(bbcad8f)</span></li>

 <li>libs/pigment/KoCopyColorConversionTransformation.h <span style="color: grey">(b5db364)</span></li>

 <li>libs/pigment/KoCopyColorConversionTransformation.cpp <span style="color: grey">(255f546)</span></li>

 <li>libs/pigment/KoFallBackColorTransformation.cpp <span style="color: grey">(f6ab183)</span></li>

 <li>libs/pigment/KoMultipleColorConversionTransformation.h <span style="color: grey">(0c9580e)</span></li>

 <li>libs/pigment/KoMultipleColorConversionTransformation.cpp <span style="color: grey">(b94e205)</span></li>

 <li>libs/pigment/colorspaces/KoAlphaColorSpace.h <span style="color: grey">(ba70b17)</span></li>

 <li>libs/pigment/colorspaces/KoAlphaColorSpace.cpp <span style="color: grey">(95bf868)</span></li>

 <li>libs/pigment/colorspaces/KoSimpleColorSpace.h <span style="color: grey">(594f7c9)</span></li>

 <li>libs/pigment/colorspaces/KoSimpleColorSpaceEngine.h <span style="color: grey">(b9cadde)</span></li>

 <li>libs/pigment/colorspaces/KoSimpleColorSpaceEngine.cpp <span style="color: grey">(cd20cc1)</span></li>

 <li>plugins/colorengines/lcms2/IccColorSpaceEngine.h <span style="color: grey">(5328e26)</span></li>

 <li>plugins/colorengines/lcms2/IccColorSpaceEngine.cpp <span style="color: grey">(ad9b3e5)</span></li>

 <li>plugins/colorengines/lcms2/tests/TestKoCompositeOps.cpp <span style="color: grey">(22d7132)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105266/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>