<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105896/">http://git.reviewboard.kde.org/r/105896/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Thorsten Zachmann.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When investigating the reason for crash for bug 304674 I found out that a very a bug had sneeked in during some refactor of the KoDocumentResourceProvider and KoCanvasResourceProvider. The problem there was that the canvas resource current page had changed and that triggered a repaint which resulted in a crash (Crash fixed by a better fix). However the reason there was a repaint was that the signal for changing the current page resource triggered in KoPathTool::resourceChanged the trigger for HandleRadius as both resource providers did trigger the same slot with oververlapping resources :-(. Seems like this was not the only place where this was done. I have fixed that by adding a second slot for the documentResourceChanged and now the different slots are used for the different resources to no longer mix stuff there. I tried my best to find all occurrences of the problem.
Ok to backport to 2.5?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before the crash fix this change made sure the crash is gone as the code no longer triggered the wrong resource change.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>karbon/plugins/tools/KarbonGradientTool.h <span style="color: grey">(40d3645)</span></li>
<li>karbon/plugins/tools/KarbonGradientTool.cpp <span style="color: grey">(0e7479a)</span></li>
<li>karbon/plugins/tools/KarbonPatternTool.h <span style="color: grey">(093932b)</span></li>
<li>karbon/plugins/tools/KarbonPatternTool.cpp <span style="color: grey">(5a783be)</span></li>
<li>libs/flake/KoToolBase.h <span style="color: grey">(2d203b6)</span></li>
<li>libs/flake/KoToolBase.cpp <span style="color: grey">(f0f1ad1)</span></li>
<li>libs/flake/KoToolBase_p.h <span style="color: grey">(95d5bd7)</span></li>
<li>libs/flake/tools/KoCreatePathTool.h <span style="color: grey">(442e5ce)</span></li>
<li>libs/flake/tools/KoCreatePathTool.cpp <span style="color: grey">(6651a3a)</span></li>
<li>libs/flake/tools/KoPathTool.h <span style="color: grey">(abb4e1a)</span></li>
<li>libs/flake/tools/KoPathTool.cpp <span style="color: grey">(6fb89df)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105896/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>