<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105700/">http://git.reviewboard.kde.org/r/105700/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit cddfd01a711b1ed43d1f357e93112cc04f6cad6d by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 23rd, 2012, 9:39 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Cyrille Berger Skott.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 23, 2012, 9:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As I haven't done enough review requests today... ;)
The tool for the webshape has still the name "State tool" (seems that was the code origin template).
Also the option widget title "Web tool options" seems unneeded, given there is only one option widget for the tool. Only results in UI clutter.
Patch fixes the name to be "Web Shape Tool" and simply removes the option title widget.
For 2.5 I wonder if instead of backporting this patch (string change) rather the webshape plugin should be completely disabled:
* behaves strange on zoom change of the view of the document it is contained in
* no possibility to zoom the content of the web page independently, so not really usable to use as kind of picture in another
Also wondering why the web shape is a braindump plugin and not a general Calligra one.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>braindump/plugins/webshape/WebTool.cpp <span style="color: grey">(3a8770a)</span></li>
<li>braindump/plugins/webshape/WebToolFactory.cpp <span style="color: grey">(9983b7d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105700/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>