<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105771/">http://git.reviewboard.kde.org/r/105771/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good
I'm a bit scared about the part where you set the documentlayout data. There is some fine timings invoved there, so make sure you don't reopen the bug where the font of the textshape in for example krita becomes unset/inconsistant.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105771/diff/2/?file=75107#file75107line74" style="color: black; font-weight: bold; text-decoration: underline;">libs/textlayout/KoTextLayoutTableArea.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">74</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">KoTableCellStyle</span> <span class="n">KoTextLayoutTableArea</span><span class="o">::</span><span class="n">Private</span><span class="o">::</span><span class="n">effectiveCellFormat</span><span class="p">(</span><span class="k">const</span> <span class="n">QTextTableCell</span> <span class="o">&</span><span class="n">tableCell</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">since we return a style the method should probably be renamed</pre>
</div>
<br />
<p>- C.</p>
<br />
<p>On July 28th, 2012, 4:08 p.m., Gopalakrishna Bhat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Gopalakrishna Bhat.</div>
<p style="color: grey;"><i>Updated July 28, 2012, 4:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add support for templates in table.
LO saves a invalid ODF attribute text:style-name for table:table-template element, so created a workaround for that while loading. Do we need to create this workaround while saving also(doing so will create an invalid ODF)?</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=277764">277764</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoOdfWorkaround.h <span style="color: grey">(ffeb463)</span></li>
<li>libs/flake/KoOdfWorkaround.cpp <span style="color: grey">(d6aff39)</span></li>
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(7146ffa)</span></li>
<li>libs/kotext/KoTextTableTemplate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoTextTableTemplate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(1ea701c)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.h <span style="color: grey">(dd10b19)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.cpp <span style="color: grey">(84df888)</span></li>
<li>libs/kotext/opendocument/KoTextSharedSavingData.h <span style="color: grey">(1d4f301)</span></li>
<li>libs/kotext/opendocument/KoTextSharedSavingData.cpp <span style="color: grey">(ec6b368)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.cpp <span style="color: grey">(1b3ae9d)</span></li>
<li>libs/kotext/styles/KoStyleManager.h <span style="color: grey">(d787bb6)</span></li>
<li>libs/kotext/styles/KoStyleManager.cpp <span style="color: grey">(b207f40)</span></li>
<li>libs/kotext/styles/KoTableCellStyle.h <span style="color: grey">(72d8cc7)</span></li>
<li>libs/kotext/styles/KoTableCellStyle.cpp <span style="color: grey">(3104306)</span></li>
<li>libs/kotext/styles/KoTableStyle.h <span style="color: grey">(67bd704)</span></li>
<li>libs/odf/CMakeLists.txt <span style="color: grey">(ce45ade)</span></li>
<li>libs/odf/KoGenStyles.cpp <span style="color: grey">(1dc2f40)</span></li>
<li>libs/odf/KoOdfStylesReader.h <span style="color: grey">(9e77434)</span></li>
<li>libs/odf/KoOdfStylesReader.cpp <span style="color: grey">(3da03b9)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.h <span style="color: grey">(5715b43)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.cpp <span style="color: grey">(7621652)</span></li>
<li>libs/textlayout/KoTextLayoutTableArea.cpp <span style="color: grey">(45e19c9)</span></li>
<li>plugins/textshape/TextShape.h <span style="color: grey">(dc513c9)</span></li>
<li>plugins/textshape/TextShape.cpp <span style="color: grey">(f707e4b)</span></li>
<li>plugins/textshape/TextShapeFactory.cpp <span style="color: grey">(4e6d817)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105771/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>