<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105736/">http://git.reviewboard.kde.org/r/105736/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 27th, 2012, 9:37 a.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It actually looks quite nice to me. If you want to do unit tests that would be preferable, but if not we can ship it as is.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While I very much value unit tests, I have not yet completely got a feeling/idea for the style system and am currently working on fixing/extending the background color/image/fill to get a better feeling, so would prefer to do the unit tests only later.
So, ship it for master and 2.5?</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On July 26th, 2012, 10:15 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and C. Boemann.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 26, 2012, 10:15 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Current draft of code to at least keep the data read from style:column and style:column-gap elements and also write it again.
To make it complete I also changed KoPagePreviewWidget and KWFrameLayout to use the columndata if present, so the layout is not messed and results in broken looking display.
I have no real idea about the KoSectionStyle code, as I could not test it. And I also have not yet done any unit tests.
But feedback is already welcome.
Candidate for backport to 2.5, due to the otherwise data loss.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Roundtrips of documents between LO 3.5 and Calligra master with this patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/styles/KoSectionStyle.h <span style="color: grey">(7d06a9e)</span></li>
<li>libs/kotext/styles/KoSectionStyle.cpp <span style="color: grey">(294a85a)</span></li>
<li>libs/odf/CMakeLists.txt <span style="color: grey">(ce45ade)</span></li>
<li>libs/odf/KoColumns.h <span style="color: grey">(6bd7267)</span></li>
<li>libs/odf/KoColumns.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoPagePreviewWidget.cpp <span style="color: grey">(8fe2c68)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(014e106)</span></li>
<li>words/part/KWPageStyle.cpp <span style="color: grey">(ebc9103)</span></li>
<li>words/part/KWRootAreaProvider.cpp <span style="color: grey">(d4a0a9b)</span></li>
<li>words/part/dialogs/KWDocumentColumns.cpp <span style="color: grey">(f0ab3cf)</span></li>
<li>words/part/frames/KWFrameLayout.cpp <span style="color: grey">(a99cfb8)</span></li>
<li>words/part/tests/TestFrameLayout.cpp <span style="color: grey">(312e6ce)</span></li>
<li>words/part/tests/TestPageCommands.cpp <span style="color: grey">(4f1f46f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105736/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>