<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105692/">http://git.reviewboard.kde.org/r/105692/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, please. And thanks for all the painstaking checking :-)</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On July 23rd, 2012, 3:51 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 23, 2012, 3:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the "Layers" docker of Krita, the context menu of layers tries to use the icons "edit-duplicate" and "edit-merge", but they do not exist.
Patch fixes this:
* by using "edit-copy" for the "Duplicate Layer or Mask" action, like it is also done in the toolbar at the bottom of the docker for the very same action (and by KPrViewModeSlidesSorter for the button with the action "Duplicate Slide" or by Braindump's SectionsBoxDock for the duplicate button)
* by using no icon for the action "Merge with Layer Below"
So this fix is not perfect, but consistent how the problem of a missing "edit-duplicate" icon is solved in other places.
Okay to backport to 2.5?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp <span style="color: grey">(61141a3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105692/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>