<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105650/">http://git.reviewboard.kde.org/r/105650/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. Good work. Please commit.
Should we ask an aartist to come up with the icons?
If you continue to work on it I thing that widget is a bit to wide for my taste. Not sure why that is.</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On July 21st, 2012, 11:35 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 21, 2012, 11:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The dialog for the guides tool looked a little confusing to me (besides the three icons missing):
* the erase-previous-guides checkbox was lined with the put-guides-at-x-edge checkboxes
* the put-guides-at-x-edge checkboxes were not lined with the number-of-guides inputs
* to add guides, first the checkbox for the orientation has to be clicked to enable, then only the number-of-guides input
* order is vertical, then horizontal, while in other places it is horizontal, then vertical
Attached patch fixes all that, by
* using order horizontal, then vertical
* removing the checkboxes for the orientation and using None value for no guides
* moving the put-guides-at-x-edge checkboxes behind the respective number-of-guides input
* turning the icon-only erase-previous-guides checkbox into a text-only one, for more expliteness (and removing need for icon)
Not yet perfect, but a little better than before IMHO.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/defaultTools/guidestool/InsertGuidesToolOptionWidget.h <span style="color: grey">(7fad354)</span></li>
<li>plugins/defaultTools/guidestool/InsertGuidesToolOptionWidget.cpp <span style="color: grey">(21ab34b)</span></li>
<li>plugins/defaultTools/guidestool/InsertGuidesToolOptionWidget.ui <span style="color: grey">(91059d1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105650/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105650/s/640/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/21/GuidesToolDialogBefore_400x100.png" style="border: 1px black solid;" alt="Before" /></a>
<a href="http://git.reviewboard.kde.org/r/105650/s/641/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/21/GuidesToolDialogAfter_400x100.png" style="border: 1px black solid;" alt="After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>