<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105618/">http://git.reviewboard.kde.org/r/105618/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Michael O'Sullivan.</div>
<p style="color: grey;"><i>Updated July 19, 2012, 10:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch addresses Bug 299844: In Krita using a shape tool creates new vector/shape layer even if a vector layer is selected.
The bug was caused by calls to KisSystemLocker for the current node that meant the activeLayer failed its isEditable test, and instead a new layer was created for the shape. The bug affected the rectangle, ellipse, polyline, and polygon tools. The polyline tool worked correctly however. Changes were made to the above tools so that they were consistent with the invocation of KisSystemLocker in the kis_tool_path.cc implementation.
This bug would be prominent in attempts to follow the workflow showcased in the Comics with Krita DVD.
Many thanks to Sven Langkamp for much patient guidance.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The tools have been used to paint in both vector and paint layers, with copying and resizing, and seem to work as expected.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=299844">299844</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/tools/defaulttools/kis_tool_ellipse.cc <span style="color: grey">(64af967)</span></li>
<li>krita/plugins/tools/defaulttools/kis_tool_rectangle.cc <span style="color: grey">(9d6997e)</span></li>
<li>krita/plugins/tools/tool_polygon/kis_tool_polygon.cc <span style="color: grey">(e5edd5e)</span></li>
<li>krita/plugins/tools/tool_polyline/kis_tool_polyline.cc <span style="color: grey">(feeeb57)</span></li>
<li>krita/ui/tool/kis_tool_ellipse_base.cpp <span style="color: grey">(4384850)</span></li>
<li>krita/ui/tool/kis_tool_polyline_base.cpp <span style="color: grey">(053fe6e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105618/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>