<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105589/">http://git.reviewboard.kde.org/r/105589/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e0796fa74825c8f4dd0005d679d46dfae6fcf6d6 by Thorsten Zachmann to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 18th, 2012, 5:15 a.m., Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jan Hambrecht.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated July 18, 2012, 5:15 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes loading of draw:image of the type svg in case the mimetype is not provided as in the document attached to the bug report.
When the mime type is not found we try to guess it by the content of the file. To do that we read the first 16K data and pass it to KMimeType.
After we found out the mime type we also set it so it is there for later usage.
Ok to backport to 2.5</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the above file and it is working nicely.
Please note that the svg is parsted into odf data structures and therefore we don't save the svg when we save the document.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=303587">303587</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/svg/SvgShapeFactory.cpp <span style="color: grey">(95602c0)</span></li>
<li>libs/odf/KoOdfLoadingContext.h <span style="color: grey">(c8481ec)</span></li>
<li>libs/odf/KoOdfLoadingContext.cpp <span style="color: grey">(569cfd0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105589/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>