<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105604/">http://git.reviewboard.kde.org/r/105604/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 638bc14ebaf23f185f6657bc3057d61397a1bb01 by Friedrich W. H. Kossebau to branch calligra/2.5.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 18th, 2012, 2:05 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 18, 2012, 2:05 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Current parsing code for fo:border in KoParagraphStyle was not taking into account all the possible data variation in the value string to parse.
Attached fixes that. As a result "TestOpenDocumentStyle testParagraphStyle" does no longer fail on the attribute fo:border (only on style:shadow, fix coming as separate review request).
Also changes a bad test value (0cm, while only positive integer are allowed here).
Okay to backport to 2.5?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/styles/KoParagraphStyle.cpp <span style="color: grey">(820da77)</span></li>
<li>libs/kotext/styles/tests/TestOpenDocumentStyle.cpp <span style="color: grey">(d0aadd4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105604/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>