<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105583/">http://git.reviewboard.kde.org/r/105583/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry that I missed this review request. Looks good to me, indeed please backport too.</pre>
<br />
<p>- Marijn</p>
<br />
<p>On July 15th, 2012, 6:20 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Marijn Kruisselbrink and C. Boemann.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 15, 2012, 6:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The running Calligra sheets currently has as icon the "unknown" icon.
Reason is that the icon installed is still named "*-kspread" and also used by that name in all-but-one places.
This place is "AboutData", which has set as icon name the string "sheets", as by default set from the app id.
Also still using the id "kspread" for the icon is not perfect from a consistent appearance POV :)
Attached patch renames the installed icons to *-sheets and also adapts all places which used the "kspread" icon name.
(Only nitpick is that the actual icons are still the old ones from KOffice 1.* times(?), as the new ones are not yet done.
But those are still better than the "unknown" :) )
Okay to backport to 2.5?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>active/qml/DocumentTypeSelector.qml <span style="color: grey">(73fecf0)</span></li>
<li>sheets/CMakeLists.txt <span style="color: grey">(41ce521)</span></li>
<li>sheets/data/pics/hi16-app-kspread.png <span style="color: grey">(2fc3d86)</span></li>
<li>sheets/data/pics/hi16-app-sheets.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>sheets/data/pics/hi22-app-kspread.png <span style="color: grey">(9f8c807)</span></li>
<li>sheets/data/pics/hi22-app-sheets.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>sheets/data/pics/hi32-app-kspread.png <span style="color: grey">(5161357)</span></li>
<li>sheets/data/pics/hi32-app-sheets.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>sheets/data/pics/hi48-app-kspread.png <span style="color: grey">(b908ae9)</span></li>
<li>sheets/data/pics/hi48-app-sheets.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>sheets/part/CellToolFactory.cpp <span style="color: grey">(4573c10)</span></li>
<li>sheets/sheets.desktop <span style="color: grey">(af637b0)</span></li>
<li>sheets/sheetspart.desktop <span style="color: grey">(09f494e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105583/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>