<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105501/">http://git.reviewboard.kde.org/r/105501/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 12th, 2012, 10:15 p.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I could have sworn I saw a ship-it by Dag for this, or was that a similar request for Plan?
</pre>
</blockquote>
<p>On July 12th, 2012, 10:28 p.m., <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I splitted between Sheets and Plan, hoping to split the review effort needed.
But currently most of the reviews seem to end up with you anyway :)
Many thanks for all the reviewing, really great to see my requests not catching any dust (unless quite tricky or big, like the koIcon one)!
I feel bad not being responsible for anything myself, so I do not have to do reviewing myself :) But my interest currently simply jumps around between all places in Calligra (well, to the issues I see). </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Heh, Well I do feel a bit stressed by all your requests. I wish more people would be able to help reviewing, or you would slow down. Well I don't really want you to slow down. You are doing a great job, many thanks, but it does takes it's toll :)
And you don't have to be responsible of anything to do a review. It's not supposed to be a maintainer's approval, but just peer review, so if you see some requests where you know something or can just check for basic saneness or run a compile or whatever seems appropriate reviewing, by all means do it.
As for this request, since the similar one have already been approved and worked without problems, let's approve this one too</pre>
<br />
<p>- C.</p>
<br />
<p>On July 10th, 2012, 6:18 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Marijn Kruisselbrink.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 10, 2012, 6:18 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In kdelibs 4.4 KLocale::fragDigits was split into KLocale::monetaryDecimalNumbers and KLocale::decimalNumbers.
While the deprecated KLocale::fragDigits at least in 4.8 maps to KLocale::monetaryDecimalNumbers (though not documented in the API, just implementation), for me it still feels better to use the correct property directly if compiled against 4.4 and later. And in OpenCalcExport::exportDefaultCellStyle() it should be rather KLocale::decimalNumbers, not KLocale::monetaryDecimalNumbers, from what I understand.
Also cleans the build output from the "Deprecated!" warnings :)
Patch also fixes Localization::defaultSystemConfig() still using "tables" and not "sheets" as id.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/sheets/opencalc/opencalcexport.cc <span style="color: grey">(383d328)</span></li>
<li>sheets/Localization.cpp <span style="color: grey">(6989f4e)</span></li>
<li>sheets/ui/CellToolBase.cpp <span style="color: grey">(89b79f9)</span></li>
<li>sheets/ui/CellToolBase_p.cpp <span style="color: grey">(bbfe480)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105501/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>