<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105429/">http://git.reviewboard.kde.org/r/105429/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit de21ca6fee6b50064eb27b9f21be4faac4fe7f0f by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 3rd, 2012, 10:52 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Cyrille Berger Skott.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 3, 2012, 10:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As can be seen with the Design Templates in Krita, the KIconLoader based on the componentData of the part does not find icons in the calligra dir.
The reason is that it never learned about the calligra icons, only the global iconloader did (which is based on the main componentData which is set by KoApplication).
Also creating a KIconLoader instance is quite expensive, as it scans all folders (from what I can tell), so better not do that on the fly.
Basing the used KIconLoader directly on the component data to make sure the document type/app specific icon dirs are used is not needed ATM, as KoDocuments are only used in KoApplications currently. I started a bigger patch which adds a KIconLoader instance to each document factory, but that got a bigger patch in making it complete. There are also quite some KIcon usages (which defaults to use the global KIconLoader), so the real fix would be even greater. So I stayed away from that and spared you the review :) I have already enough review request put in the pipe ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used Template creation dialog and Templates pane in Words, Krita, and others.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/KoOpenPane.cpp <span style="color: grey">(568ce88)</span></li>
<li>libs/main/KoTemplate.h <span style="color: grey">(2505126)</span></li>
<li>libs/main/KoTemplate.cpp <span style="color: grey">(e74aaa4)</span></li>
<li>libs/main/KoTemplateCreateDia.cpp <span style="color: grey">(c6b79f8)</span></li>
<li>libs/main/KoTemplatesPane.cpp <span style="color: grey">(cc76c05)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105429/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>