<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105503/">http://git.reviewboard.kde.org/r/105503/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 1319567215dff567d50af21e4d93deb127a4f0e8 by Friedrich W. H. Kossebau to branch calligra/2.5.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 10th, 2012, 2:49 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Inge Wallin.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated July 10, 2012, 2:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some calligratests like interoperability/wordprocessing/oowriter/oow_embede_audio.odt fail on a bad xml:id for the draw:plugin element.
Reason is that PluginShape currently has a property xmlid, which only gets set on loading. On saving the content of that property is written, even if empty (like for the file above).
Attached patch fixes this by doing like the rest(?) of Calligra, dropping any read xmlid and generating in any case a new one on saving.
(Also fixes a bad i18n-with-parameter call and deprecated QString::null usages, or should those be in separate commits?)
Okay to backport to 2.5?
PS: In general I think Calligra should try to remember the read xml-ids, it kind-of spoils the idea of ids if those are completely new after saving, even for untouched elements. But that is not in the scope of this fix, which only cares for writing valid ODF.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/pluginshape/PluginShape.h <span style="color: grey">(38c67db)</span></li>
<li>plugins/pluginshape/PluginShape.cpp <span style="color: grey">(c1e19ec)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105503/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>